Middle-clicking the selected tab should not focus the tab bar

VERIFIED FIXED in Firefox 3.6a1

Status

()

defect
--
trivial
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: j.moz, Assigned: dao)

Tracking

({verified1.9.1})

Trunk
Firefox 3.6a1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Follow-up to bug 462289:

Middle-clicking the selected tab still focuses the tab bar on mousedown, before closing the tab on mouseup. The tab bar should not be focused.

Steps to reproduce:
1) Click (and don't release) the current tab on the tab bar with the *middle* mouse button, don't release the button yet.

What happens: the tab bar is focused
What should've happened: nothing yet

(you can release the middle button now, and the tab closes)
Blocks: 462289
No longer depends on: 462289
Severity: normal → trivial
Better steps to reproduce:

1) Middle-click and hold (start "middle-dragging") the current tab
2) Move the mouse cursor down until it's over the page content
3) Release the middle mouse button

What happens: the tab bar is focused
What should've happened: nothing
Blocks: 490465
Assignee: nobody → dao
Posted patch patchSplinter Review
It's not clear to me why style updates need to be flushed there, I've just copied this from the other handler.

I'd like to get this into 3.5 for bug 490465.
Attachment #375190 - Flags: review?(gavin.sharp)
Attachment #375190 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/2f8e64eb3691
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Attachment #375190 - Flags: approval1.9.1?
Comment on attachment 375190 [details] [diff] [review]
patch

a191=beltzner. This also needs a test.
Attachment #375190 - Flags: approval1.9.1? → approval1.9.1+
Keywords: checkin-needed
verified FIXED on builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090604 Shiretoko/3.5pre (.NET CLR 3.5.30729) ID:20090604045218

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090604 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090604042555
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.