482801 - Middle-clicking the selected tab should not focus the tab bar

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Joonas]

Follow-up to bug 462289:

Middle-clicking the selected tab still focuses the tab bar on mousedown, before closing the tab on mouseup. The tab bar should not be focused.

Steps to reproduce:
1) Click (and don't release) the current tab on the tab bar with the *middle* mouse button, don't release the button yet.

What happens: the tab bar is focused
What should've happened: nothing yet

(you can release the middle button now, and the tab closes)

Comment 1

[Joonas]

Better steps to reproduce:

1) Middle-click and hold (start "middle-dragging") the current tab
2) Move the mouse cursor down until it's over the page content
3) Release the middle mouse button

What happens: the tab bar is focused
What should've happened: nothing

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

It's not clear to me why style updates need to be flushed there, I've just copied this from the other handler.

I'd like to get this into 3.5 for bug 490465.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/2f8e64eb3691

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 375190 [details] [diff] [review]
patch

a191=beltzner. This also needs a test.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/0f8895e7620a

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ec47d4d431e8

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090604 Shiretoko/3.5pre (.NET CLR 3.5.30729) ID:20090604045218

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090604 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090604042555