482856 - Inconsistent comment for hiding pages in nsNavHistory

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Andreas Wagner [:TheOne] [use NI]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7

In http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp#2703 it is said:

"Rather, we want to hide pages that do not themselves redirect somewhere else..."

That seems not logical, and the code below that comment executes the contrary:

if (hidden == 1 && (!aIsRedirect || aTransitionType == TRANSITION_TYPED) && aTransitionType != TRANSITION_EMBED) hidden = 0; // unhide

The comment should be changed to:
"Rather, we want to hide pages that redirect themselves somewhere else..."


Reproducible: Always

Comment 1

[Andreas Wagner [:TheOne] [use NI]]

Attachment: patch correcting the comment

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 373866 [details] [diff] [review]
patch correcting the comment

sounds correct to me, thanks.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/21ae77198510

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/41086f965e7d