482880 - l10n verify has duplicated results for win32

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We unpack the win32 installers with 7z to get nonlocalized, localized, and optional directories, then copy everything from these dirs into bin/.
 http://hg.mozilla.org/build/tools/file/a68f697e2be8/release/common/unpack.sh#l33
This is done for en-US in a directory source/, and each locale in target/, and then we 'diff source target' - which finds differences in both copies of each file and makes the diff confusing to read.

Really just need to the diff on source/bin, or remove the three source dirs after unpacking.

Comment 1

[Chris Cooper [:coop] (he/him)]

Attachment: Remove the dirs after we copy them into bin/

Easiest just to delete the offending dirs once we've got their contents IMO.

Tested this patch on fx-mac-1.9-slave2 and we get simpler win32 diffs without seeming to affect the meta-diff.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 369351 [details] [diff] [review]
Remove the dirs after we copy them into bin/

Woah, completely missed this one. Sorry about that.

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 369351 [details] [diff] [review]
Remove the dirs after we copy them into bin/

changeset:   254:3669bbad0ca4