Closed Bug 482899 Opened 16 years ago Closed 16 years ago

Don't call the reviver function when the JSON parse fails

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sayrer, Assigned: sayrer)

References

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

exit early, fix jsval naming nit, add test
1.73 KB, patch
Waldo
: review+
Details | Diff | Splinter Review
Should return early after reporting a parse error in JS_FinishJSONParse.
Attachment #366994 - Attachment is obsolete: true
Comment on attachment 366995 [details] [diff] [review] exit early, fix jsval naming nit, add test Hm, I missed the v/vp name-botch. Bad me!
Attachment #366995 - Flags: review+
Flags: blocking1.9.1+
Assignee: general → sayrer
Blocks: 482861
http://hg.mozilla.org/tracemonkey/rev/41abbad16fe1
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/41abbad16fe1
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
covered by the json unit tests.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: