482939 - Need to use nsAutoMonitor::New/DestroyMonitor when using nsAutoMonitor to grab monitors

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Code under security/manager/ssl and security/manager/boot uses nsAutoMonitor to acquire and release PRMonitors, but uses PR_NewMonitor and PR_DestroyMonitor to create and destroy them. It should use nsAutoMonitor::NewMonitor and nsAutoMonitor::DestroyMonitor to avoid causing spurious "potential deadlock warnings". See bug 482938 for more information.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Kaie, how about a review here?

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 367016 [details] [diff] [review]
fix

r=kaie

thanks for the patch!

We should do the same for nsClientAuthRemember.cpp

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Additional patch

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This needs approvals now.

Comment 5

[Benjamin Smedberg]

Comment on attachment 367016 [details] [diff] [review]
fix

a=me for both

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/e5d2c136dcda
http://hg.mozilla.org/mozilla-central/rev/5e08304cbc99