Closed Bug 482939 Opened 11 years ago Closed 9 years ago

Need to use nsAutoMonitor::New/DestroyMonitor when using nsAutoMonitor to grab monitors

Categories

(Core :: Security: PSM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(2 files)

Attached patch fixSplinter Review
Code under security/manager/ssl and security/manager/boot uses nsAutoMonitor to acquire and release PRMonitors, but uses PR_NewMonitor and PR_DestroyMonitor to create and destroy them. It should use nsAutoMonitor::NewMonitor and nsAutoMonitor::DestroyMonitor to avoid causing spurious "potential deadlock warnings". See bug 482938 for more information.
Attachment #367016 - Flags: review?(kaie)
Assignee: kaie → roc
Kaie, how about a review here?
Whiteboard: [needs review]
Comment on attachment 367016 [details] [diff] [review]
fix

r=kaie

thanks for the patch!

We should do the same for nsClientAuthRemember.cpp
Attachment #367016 - Flags: review?(kaie) → review+
Attached patch Additional patchSplinter Review
Attachment #449725 - Flags: review?(roc)
Whiteboard: [needs review]
Whiteboard: [needs landing]
Attachment #449725 - Flags: review?(roc) → review+
This needs approvals now.
Keywords: checkin-needed
Whiteboard: [needs landing]
Comment on attachment 367016 [details] [diff] [review]
fix

a=me for both
Attachment #367016 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Attachment #449725 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/e5d2c136dcda
http://hg.mozilla.org/mozilla-central/rev/5e08304cbc99
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.