Closed Bug 482955 Opened 15 years ago Closed 15 years ago

Minimum Luna textbox size does not honour content

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: fixed1.9.1)

Attachments

(3 files)

Test case
413 bytes, application/vnd.mozilla.xul+xml
Details
Proposed patch
1.66 KB, patch
emaijala+moz
: review+
roc
: superreview+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
Reftest
1.26 KB, patch
roc
: review+
Details | Diff | Splinter Review 
ClassicGetMinimumWidgetSize does not set a size for a textbox, but GetMinimumWidgetSize does when Luna is active. This means that XBL-generated content added to a textbox (such as the autocomplete dropmarker used in the test case to follow) does not affect the textbox's minimum size and gets drawn outside the textbox if other constraints shrink the textbox too far.
Attached file Test case — 
Note: I only tested the autocomplete behaviour with SeaMonkey but I believe the toolkit autocomplete binding has a similar layout.
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil

        Attachment #367038 -
        Flags: superreview?(roc)

        Attachment #367038 -
        Flags: review?

    
  

        Attachment #367038 -
        Flags: review? → review?(emaijala)

        Attachment #367038 -
        Flags: superreview?(roc) → superreview+

    
  

        Attachment #367038 -
        Flags: review?(emaijala) → review+

    
    

    
  
Pushed changeset 8de47d925928 to mozilla-central.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 367038 [details] [diff] [review]
Proposed patch

Requesting approval for 1.9.1 since this is blocking SeaMonkey Bug 435652

        Attachment #367038 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 367038 [details] [diff] [review]
Proposed patch

a191=beltzner

        Attachment #367038 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Also, can we generate a test for this, please?

    
    

    
  
(In reply to comment #6)
> Also, can we generate a test for this, please?
Can we guarantee that the Windows tinderboxes will use Luna? Or should I just adapt the test case because it will now pass on all configurations?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Reftest
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #373638 -
        Flags: review?(roc)

    
    

    
  
Comment on attachment 373638 [details] [diff] [review]
Reftest

Pushed changeset d1f0f3fc43ea to mozilla-central.

    
    

    
  
Pushed changesets b902105ee2e1 and 314c9a199d39 to releases/mozilla-1.9.1
Keywords: fixed1.9.1

          You need to log in
          before you can comment on or make changes to this bug.