Closed Bug 482975 Opened 15 years ago Closed 12 years ago

browser_477657.js is unreliable | the window was maximized - Got 3, expected 1 or | the window was explicitly unmaximized - Didn't expect 1, but got it

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 12

People

(Reporter: dao, Assigned: zpao)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Patch v0.2 (what landed)
2.14 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
see bug 477657 comment 12:

> on mac:
> the window was explicitly unmaximized - Didn't expect 1, but got it
> 
> and windows:
> the window was maximized - Got 3, expected 1

I'm going to disable the test now.
Blocks: 438871
Whiteboard: [orange]
Whiteboard: [orange] → [orange][test disabled]
Depends on: 528440
The test is now disabled for OS X only.
Whiteboard: [orange][test disabled] → [orange][test disabled for OS X]
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269522054.1269523158.16222.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/03/25 06:00:54
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269595289.1269596094.3271.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/03/26 02:21:29
s: win32-slave16
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269822045.1269822798.14303.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/03/28 17:20:45
s: win32-slave40
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270050312.1270051084.4435.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/03/31 08:45:12
s: win32-slave41
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/04/05 00:40:13  
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270453213.1270453899.10820.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270548645.1270549259.2553.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/04/06 03:10:45
s: win32-slave27
Summary: browser_477657.js is unreliable → browser_477657.js is unreliable | the window was maximized - Got 3, expected 1
Summary: browser_477657.js is unreliable | the window was maximized - Got 3, expected 1 → browser_477657.js is unreliable | the window was maximized - Got 3, expected 1 or | the window was explicitly unmaximized - Didn't expect 1, but got it
https://tbpl.mozilla.org/php/getParsedLog.php?id=7802750&tree=Mozilla-Inbound

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_477657.js | the window was explicitly unmaximized - Didn't expect 1, but got it
So, what are we thinking - wait until it hits #c500 before I disable those two parts of the test, or just dump them now?
Attached patch Patch v0.1 (obsolete) — — Splinter Review 
I'd be curious as to what caused this bug to get super hot the past couple months, but using executeSoon instead of setTimeout is probably better anyway, though I wouldn't be surprised if this could still go orange.
Assignee: nobody → paul
Attachment #590921 - Flags: review?(dietrich)
Attachment #590921 - Flags: review?(dietrich) → review+
(In reply to Paul O'Shannessy [:zpao] from comment #944)
> I'd be curious as to what caused this bug to get super hot the past couple
> months, but using executeSoon instead of setTimeout is probably better
> anyway, though I wouldn't be surprised if this could still go orange.

Why would executeSoon work when setTimeout doesn't?

I could see using newWin.setTimeout() might be more reliable, though, since that should be the same window where sss_restoreWindowFeatures sets its timeout.
After talking with Gavin, I just used newWin.setTimeout instead of executeSoon.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e4ff4aa33a6

        Attachment #590921 -
        Attachment is obsolete: true

        Attachment #591865 -
        Flags: review?

        Attachment #591865 -
        Flags: review? → review+

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0e4ff4aa33a6

Should this test be re-enabled for OS X now?
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
(In reply to Matt Brubeck (:mbrubeck) from comment #1077)
> https://hg.mozilla.org/mozilla-central/rev/0e4ff4aa33a6
> 
> Should this test be re-enabled for OS X now?

I think there are other sizemode event issues, but I'll look into it.

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
I re-enabled the test on OS X. If we need to disable it again we can (but we should do it in the makefile)

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6066c2d133e

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
  
Whiteboard: [orange][test disabled for OS X] → [orange]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  
Whiteboard: [orange]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: