Closed
Bug 483030
Opened 16 years ago
Closed 16 years ago
TM: Don't emit overflow guards if the operation is constant
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
2.24 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
I ran across this bug while reviewing the jit spew from https://bugzilla.mozilla.org/show_bug.cgi?id=480494.
00069: 53 setname "ret"
00073: 54 getlocal 0
00076: 54 getlocal 1
00079: 54 add
00080: 54 setlocal 0
00084: 54 goto 139 (55)
00139: 60 getarg 0
00142: 60 getlocal 1
00145: 60 sub
sti sp[8] = and4570
st fmul503[616] = and4570
sti sp[0] = ld23292
sti sp[8] = ld23291
sti sp[0] = add2705
sti sp[-24] = add2705
sti sp[0] = ld23291
sti sp[8] = ld23291
xt3884 = ov 0
xt9490: xt xt3884 -> pc=0x1e2f5301 imacpc=0x0 sp+16 rp+0
The sub operation was constant folded here, yet we are checking for overflow.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: general → gal
Attachment #367097 -
Flags: review?(danderson)
|
||
Updated•16 years ago
|
Attachment #367097 -
Flags: review?(danderson) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/797ba90aed16
P2. The failure mode are unnecessary side-exits (perf regression), not
correctness.
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Updated•16 years ago
|
Priority: -- → P2
|
||
Updated•16 years ago
|
Flags: wanted1.9.1?
|
||
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Flags: wanted1.9.1? → wanted1.9.1+
|
||
Updated•16 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•