Closed
Bug 483034
Opened 16 years ago
Closed 16 years ago
DateFormat might be wrong when displaying messages in senders time zone
Categories
(MailNews Core :: Localization, defect)
MailNews Core
Localization
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: ch.ey, Assigned: ch.ey)
Details
Attachments
(1 file)
|
3.92 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
I'm really very sorry for not having this noticed earlier (i.e. before checkin of Bug 392307). But that patch results in wrong date format chosen when using the original message format (mailnews.display.date_senders_timezone=true).
Suppose it's 2009-03-12 in time zone +0100. A message from 2009-03-11T20:49-0700 now is displayed using kDateFormatNone as "20:49 -0700" though it in fact is not from the same day and thus should use kDateFormatShort.
Determining of same day or not should occur without bringing both dates to the same time zone. Attached patch does that (which in fact results in simpler code).
Attachment #367101 -
Flags: review?(bienvenu)
|
||
Updated•16 years ago
|
Attachment #367101 -
Flags: superreview+
Attachment #367101 -
Flags: review?(bienvenu)
Attachment #367101 -
Flags: review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 367101 [details] [diff] [review]
proposed patch
thx, Christian, I've pushed this fix.
|
|
||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Target Milestone: --- → Thunderbird 3.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•