483187 - Caption of groupbox isn't correctly vertically aligned

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: wrong vertical alignment of captions

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090312 Minefield/3.2a1pre

With the fix on bug 390734 we use native theming for groupboxes on Vista. There is one minor issue left for the groupbox captions. They are not correctly vertically aligned with the surrounding border and should be pushed by 1px or 2px to the top. See the attachment which compares it with a groupbox from the keyboard settings.

Comment 1

[Robert Strong (they/them - no direct email)]

Over to toolkit -> themes where this is actually set.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 367290 [details] [diff] [review]
patch

Thanks Dão, looks good.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/7c183de433d1

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090315 Minefield/3.2a1pre ID:20090315050013

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 367290 [details] [diff] [review]
patch

Drivers, this is to fix an alignment issue with the caption for bug 390734

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 367290 [details] [diff] [review]
patch

a191=beltzner

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/97b017ab33e4

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b4pre) Gecko/20090318 Shiretoko/3.5b4pre ID:20090318051756