483327 - Options window is too tall after the landing of bug 390734

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Robert Strong (they/them - no direct email)]

bug 390734 reduced the padding and margin used by groupboxes and now there is some extra room in the options pref window.

I'm going to also fix a bug with animateFadeIn=true on Windows where the tabpanel bottom border isn't displayed.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: screenshots

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Dao: can you take this review?

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 367324 [details] [diff] [review]
patch rev1

This seems to make the window too small over here:

1. open the Options window
2. select "Content"
3. close the Options window
4. open the Options window
5. select "General"

-> the window gets taller

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 367324 [details] [diff] [review]
patch rev1

>+/* Advanced Pane */
>+#advancedPrefs {
>+  padding-bottom: 8px;
>+}

And this could use a more useful comment :)
It's pretty clear that it's about the Advanced pane, but it's not obvious what you're doing there, and why.

Comment 6

[Robert Strong (they/them - no direct email)]

Which windows version / theme are you using. With or without animateFadeIn?

No problem adding a comment about why but I want to keep the section header since that seems to be the standard in this file so people can tell what prefpane it refers to... makes it easier for those that don't work with this file often.

Comment 7

[Robert Strong (they/them - no direct email)]

The STR didn't show a problem for me on Vista.

Can I see a screenshot?

Comment 8

[Robert Strong (they/them - no direct email)]

Also wasn't able to reproduce on Vista with Classic.

Comment 9

[Dão Gottwald [:dao]]

Windows XP, Luna, animateFadeIn=false. Sure you need a screenshot? Opening the window with a pane other than "General" and switching to "General" makes the window taller -- not much to see otherwise.

Comment 10

[Dão Gottwald [:dao]]

The difference is 9 pixels... from 434 to 443.

Comment 11

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Thanks Dao

Comment 12

[Robert Strong (they/them - no direct email)]

Comment on attachment 368330 [details] [diff] [review]
patch rev2

Requesting 1.9.1 before landing on trunk since this affects l10n

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 368330 [details] [diff] [review]
patch rev2

a191=beltzner

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Rob: you gonna check this in?

Comment 15

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/861150b48c0d

I'll push this to mozilla-central once the tree is green

Comment 16

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/b59984b88601

Comment 17

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.