config.css/netError.css need a transparent Camino logo

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: phiw2, Assigned: phiw2)

Tracking

Trunk
x86
Mac OS X

Details

(Whiteboard: [camino-2.0])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Currently the images have a white opaque background.
This affects people who set their own colors in Preferences > Appearance and check the 'Always use' box. About:config and netError.xhtml look odd in that case.

Sam, do you have the original artwork for that (Camino logo with alert icon) ? PSD @ 100px by 100px
(Assignee)

Comment 1

10 years ago
Oops, how did I get the browser in that state ? 
Preferences > Appearance, 'always us my colors' suppresses the images in those About:config and netError.xhtml files.

Still the point stands, in case the background-color in the stylesheet changes.
Hm, looks like I don't have a PSD for that artwork, only a gif and (non-transparent) png. I can probably recreate this later.
I forgot about this bug with last week's icon work, but we should still fix warning.png at some point.

I believe Jon used the now-removed alert-exclam.gif for the badge (or something close; the badge has more of a shadow underneath than the original does): http://mxr.mozilla.org/mozilla1.8/source/camino/embed-replacements/skin/classic/global/icons/alert-exclam.gif
(Assignee)

Comment 4

9 years ago
Created attachment 390638 [details]
warning.png transparent (WIP)

(In reply to comment #3)

> I believe Jon used the now-removed alert-exclam.gif for the badge (or something
> close; the badge has more of a shadow underneath than the original does):
> http://mxr.mozilla.org/mozilla1.8/source/camino/embed-replacements/skin/classic/global/icons/alert-exclam.gif

If you open that image in Preview (assuming the default grey background), you'll see the problem to reuse it: the GIF transparency pixels. If nothing else exist, lets try to rebuild something based on that.

Attached is a wip based on that image. I mostly erased the border & shadow and only recreated those parts. It is not a 100% match, though; the rounding in the bottom corners is a bit different, and the shadow is not an exact replica...
I think I did manage to erase/hide the gif compression artifacts.

I then overlayed it over the Camino icon I used for the blacklist.png image.

Let me know what you think.
Attachment #390638 - Flags: review?(alqahira)
Comment on attachment 390638 [details]
warning.png transparent (WIP)

This looks OK; what I noticed the most was that the left (and right, to a lesser extent) edges are not as strong/black as before.  The left seems like it's disappearing into the logo.  Can that be tweaked?

I did notice the corners/shadow, but they're not very noticeable; I'm more concerned with the sides.

Now that we're using the same base image, we can simplify the CSS and have both logos in exactly the same place; patch for that forthcoming.
Attachment #390638 - Flags: review?(alqahira) → review+
Created attachment 390682 [details] [diff] [review]
netError.css unification/simplification

This makes the warning icon use the same position as the blocked icon and consolidates the rules.
Attachment #390682 - Flags: review?(phiw)
(Assignee)

Comment 7

9 years ago
Comment on attachment 390682 [details] [diff] [review]
netError.css unification/simplification

r = me for the css changes.

I'll work on a more polished image tomorrow.
Attachment #390682 - Flags: review?(phiw) → review+
(Assignee)

Comment 8

9 years ago
Created attachment 390760 [details]
warning.png v2

This ought to do it.
Better rounding in the bottom corners, better edge at the top.
Attachment #390638 - Attachment is obsolete: true
Attachment #390760 - Flags: review?(alqahira)
Comment on attachment 390760 [details]
warning.png v2

I think it might look even better than the original, at least for the sides ;) r=ardissone
Attachment #390760 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #390760 - Flags: review?(alqahira)
Attachment #390760 - Flags: review+
Comment on attachment 390682 [details] [diff] [review]
netError.css unification/simplification

This just normalizes and consolidates the CSS now that both images have the same base Camino logo.
Attachment #390682 - Flags: superreview?(stuart.morgan+bugzilla)

Comment 11

9 years ago
Comment on attachment 390682 [details] [diff] [review]
netError.css unification/simplification

sr=smorgan
Attachment #390682 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+

Comment 12

9 years ago
Comment on attachment 390760 [details]
warning.png v2

sr=smorgan
Attachment #390760 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Checked in on cvs trunk and the CAMINO_2_0_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0]
You need to log in before you can comment on or make changes to this bug.