Created attachment 367380 [details] [diff] [review] patch When a window is being restored, smooth scrolling in the tabstrip should be disabled, because a) it's actually not smooth and b) it's better to immediately get to the state in which the window was closed, i.e. with the selected tab visible.
Attachment #367380 - Flags: review?(dietrich)
Comment on attachment 367380 [details] [diff] [review] patch this idea seems ok to me, please get additional review from Simon though. nit: only set smoothScroll if changed from original value?
Attachment #367380 - Flags: review?(dietrich) → review+
(In reply to comment #1) > only set smoothScroll if changed from original value? This seems like an unnecessary complication, e.g. I'd need another variable, or make the smoothScroll variable tri-state, or something like that.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Attachment #367380 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 367380 [details] [diff] [review] patch a=191, but if you could see if you can add a quick test for this (perhaps in some of the other session restore tests?) that would be super awesome.
The test this should probably be added to, the one for bug 480148, is currently disabled...
Keywords: checkin-needed → fixed1.9.1
You need to log in before you can comment on or make changes to this bug.