Temporarily disable tabstrip smooth scrolling when restoring a window

RESOLVED FIXED in Firefox 3.6a1

Status

()

--
enhancement
RESOLVED FIXED
10 years ago
4 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug, {fixed1.9.1})

Trunk
Firefox 3.6a1
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 367380 [details] [diff] [review]
patch

When a window is being restored, smooth scrolling in the tabstrip should be disabled, because a) it's actually not smooth and b) it's better to immediately get to the state in which the window was closed, i.e. with the selected tab visible.
Attachment #367380 - Flags: review?(dietrich)
Comment on attachment 367380 [details] [diff] [review]
patch

this idea seems ok to me, please get additional review from Simon though. nit: only set smoothScroll if changed from original value?
Attachment #367380 - Flags: review?(dietrich) → review+
(Assignee)

Comment 2

10 years ago
(In reply to comment #1)
> only set smoothScroll if changed from original value?

This seems like an unnecessary complication, e.g. I'd need another variable, or make the smoothScroll variable tri-state, or something like that.
(Assignee)

Updated

10 years ago
Attachment #367380 - Flags: review?(zeniko)

Updated

10 years ago
Attachment #367380 - Flags: review?(zeniko) → review+
(Assignee)

Comment 3

10 years ago
http://hg.mozilla.org/mozilla-central/rev/4b2a90a7726e
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
(Assignee)

Updated

10 years ago
Attachment #367380 - Flags: approval1.9.1?
Attachment #367380 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 367380 [details] [diff] [review]
patch

a=191, but if you could see if you can add a quick test for this (perhaps in some of the other session restore tests?) that would be super awesome.
(Assignee)

Comment 5

10 years ago
The test this should probably be added to, the one for bug 480148, is currently disabled...
Flags: in-testsuite?
Keywords: checkin-needed
(Assignee)

Comment 6

10 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ea29bdab7238
Keywords: checkin-needed → fixed1.9.1
(Assignee)

Updated

4 years ago
Flags: in-testsuite?

Updated

4 months ago
Blocks: 1456093
You need to log in before you can comment on or make changes to this bug.