Rename the left-arrow and right-arrow class names in the print preview toolbar to previous-arrow and next-arrow

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Toolkit
Printing
--
minor
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: Away for a while, Assigned: Jae-Seong Lee-Russo)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Left does not always mean previous; in RTL locales in means next.  Ditto for right.  Therefore, we should rename the left-arrow and right-arrow class names in the print preview toolbar to something like previous-arrow and next-arrow.
(Reporter)

Updated

9 years ago
Whiteboard: [good first bug]

Comment 1

8 years ago
Created attachment 391611 [details] [diff] [review]
Renamed the class names of the right-arrow and the left-arrow
Attachment #391611 - Flags: review?(benjamin)
Kalf, [chromedir="rtl"] is obsolete. We use :-moz-locale-dir(rtl) now, but apparently your checkout isn't up-to-date.

The new class names should rather be arrow-previous and arrow-next, fwiw.

Comment 3

8 years ago
Created attachment 391821 [details] [diff] [review]
changed class names
Attachment #391611 - Attachment is obsolete: true
Attachment #391821 - Flags: review?(benjamin)
Attachment #391611 - Flags: review?(benjamin)
Comment on attachment 391821 [details] [diff] [review]
changed class names

>-.home-arrow[chromedir="rtl"] {

That line doesn't actually exist:

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/global/printPreview.css

Updated

8 years ago
Attachment #391821 - Flags: review?(benjamin) → review?(dao)
Comment on attachment 391821 [details] [diff] [review]
changed class names

As said in comment 4, this patch doesn't apply :(

You first need to update your checkout or make a new one from mozilla-central so that printPreview.css is up-to-date:

https://developer.mozilla.org/En/Developer_Guide/Source_Code/Mercurial#mozilla-central_%28main_development_tree%29
Attachment #391821 - Flags: review?(dao) → review-
(Assignee)

Comment 6

8 years ago
Created attachment 403391 [details] [diff] [review]
Rename left/right-arrow to previous/next-arrow

Tested on Windows XP

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090928 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Attachment #403391 - Flags: review?(dao)
Comment on attachment 403391 [details] [diff] [review]
Rename left/right-arrow to previous/next-arrow

thanks for the patch
Attachment #403391 - Flags: review?(dao) → review+

Updated

8 years ago
Assignee: nobody → lusian
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/58c706989c7e

I noticed that the tooltip entities also mentioned "left"/"right" and fixed that before landing.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.