483419 - Rename the left-arrow and right-arrow class names in the print preview toolbar to previous-arrow and next-arrow

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[(no longer active)]

Left does not always mean previous; in RTL locales in means next.  Ditto for right.  Therefore, we should rename the left-arrow and right-arrow class names in the print preview toolbar to something like previous-arrow and next-arrow.

Comment 1

[Kalf]

Attachment: Renamed the class names of the right-arrow and the left-arrow

Comment 2

[Dão Gottwald [:dao]]

Kalf, [chromedir="rtl"] is obsolete. We use :-moz-locale-dir(rtl) now, but apparently your checkout isn't up-to-date.

The new class names should rather be arrow-previous and arrow-next, fwiw.

Comment 3

[Kalf]

Attachment: changed class names

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 391821 [details] [diff] [review]
changed class names

>-.home-arrow[chromedir="rtl"] {

That line doesn't actually exist:

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/global/printPreview.css

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 391821 [details] [diff] [review]
changed class names

As said in comment 4, this patch doesn't apply :(

You first need to update your checkout or make a new one from mozilla-central so that printPreview.css is up-to-date:

https://developer.mozilla.org/En/Developer_Guide/Source_Code/Mercurial#mozilla-central_%28main_development_tree%29

Comment 6

[Jae-Seong Lee-Russo]

Attachment: Rename left/right-arrow to previous/next-arrow

Tested on Windows XP

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090928 Minefield/3.7a1pre (.NET CLR 3.5.30729)

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 403391 [details] [diff] [review]
Rename left/right-arrow to previous/next-arrow

thanks for the patch

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/58c706989c7e

I noticed that the tooltip entities also mentioned "left"/"right" and fixed that before landing.