483473 - Make JSObjectOps private

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

This really should not be public.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

*Not* taking this bug, because I am (I find) on a two-week vacation.

The patch builds js/src, XPConnect, and LiveConnect in a browser tree.  Should be good to land.

Comment 2

[Igor Bukanov]

Comment on attachment 367452 [details] [diff] [review]
v1


>+typedef JSObject *
>+(* JSGetMethodOp)(JSContext *cx, JSObject *obj, jsid id, jsval *vp);
>+
>+typedef JSBool
>+(* JSSetMethodOp)(JSContext *cx, JSObject *obj, jsid id, jsval *vp);
>+
>+typedef JSBool
>+(* JSEnumerateValuesOp)(JSContext *cx, JSObject *obj, JSIterateOp enum_op,
>+                        jsval *statep, jsid *idp, jsval *vp);
>+
>+typedef JSBool
>+(* JSConcatenateOp)(JSContext *cx, JSObject *obj, jsval v, jsval *vp);

These 4 types are no longer used - I forgot to remove them in the patch for bug 362910.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: v2

This patch removes the obsolete typedefs.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 370041 [details] [diff] [review]
v2

Thanks (and dieliveconnectdiediedie ;-).

/be

Comment 5

[Igor Bukanov]

The landed patch keeps JSProperty defined as a typedef in jspubtd.h. It should be moved to jsprvtd.h. I will file a new bug about it.

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/c6030369d253

Comment 7

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ec4c81492e23