Closed Bug 483589 Opened 14 years ago Closed 14 years ago

PRBool problem in nsHTMLEditor::EnableExistingStyleSheet

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: taras.mozilla, Assigned: graememcc)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Fix [Checkin: Comment 2]
1.01 KB, patch
peterv
: review+
peterv
: superreview+
dbaron
: approval1.9.1+
Details | Diff | Splinter Review 
Error: /editor/libeditor/html/nsHTMLEditor.cpp:
 3697 & 3705:   NS_ENSURE_SUCCESS(rv, rv);

http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#3705

See Taras' blog for more info about prbool bugs
http://blog.mozilla.com/tglek/2008/11/07/enabling-prcheck-email-notifications/#respond


bug 432114 is the last mod to that code, but I think the problem was there before.

        Attachment #367641 -
        Flags: superreview?(peterv)

        Attachment #367641 -
        Flags: review?(peterv)

        Attachment #367641 -
        Flags: superreview?(peterv)

        Attachment #367641 -
        Flags: superreview+

        Attachment #367641 -
        Flags: review?(peterv)

        Attachment #367641 -
        Flags: review+

        Attachment #367641 -
        Flags: approval1.9.1?

    
  
Keywords: checkin-needed

    
    

    
  
Comment on attachment 367641 [details] [diff] [review]
Fix
[Checkin: Comment 2]


http://hg.mozilla.org/mozilla-central/rev/3499bad5d5ce

        Attachment #367641 -
        Attachment description: Fix → Fix
[Checkin: Comment 2]
Assignee: nobody → graememcc_firefox
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk

    
    

    
  
Curious, any particular reason for switching to if (NS_FAILED) which doesn't warn in debug builds instead of just using NS_ENSURE_SUCCESS(rv, PR_FALSE);

    
  

        Attachment #367641 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Comment on attachment 367641 [details] [diff] [review]
Fix
[Checkin: Comment 2]

a1.9.1=dbaron

          You need to log in
          before you can comment on or make changes to this bug.