Closed
Bug 483589
Opened 16 years ago
Closed 16 years ago
PRBool problem in nsHTMLEditor::EnableExistingStyleSheet
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: taras.mozilla, Assigned: graememcc)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
1.01 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
dbaron
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Error: /editor/libeditor/html/nsHTMLEditor.cpp:
3697 & 3705: NS_ENSURE_SUCCESS(rv, rv);
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#3705
See Taras' blog for more info about prbool bugs
http://blog.mozilla.com/tglek/2008/11/07/enabling-prcheck-email-notifications/#respond
bug 432114 is the last mod to that code, but I think the problem was there before.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #367641 -
Flags: superreview?(peterv)
Attachment #367641 -
Flags: review?(peterv)
|
||
Updated•16 years ago
|
Attachment #367641 -
Flags: superreview?(peterv)
Attachment #367641 -
Flags: superreview+
Attachment #367641 -
Flags: review?(peterv)
Attachment #367641 -
Flags: review+
Attachment #367641 -
Flags: approval1.9.1?
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
Comment on attachment 367641 [details] [diff] [review]
Fix
[Checkin: Comment 2]
http://hg.mozilla.org/mozilla-central/rev/3499bad5d5ce
Attachment #367641 -
Attachment description: Fix → Fix
[Checkin: Comment 2]
|
|
||
Updated•16 years ago
|
Assignee: nobody → graememcc_firefox
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
|
||
Comment 3•16 years ago
|
||
Curious, any particular reason for switching to if (NS_FAILED) which doesn't warn in debug builds instead of just using NS_ENSURE_SUCCESS(rv, PR_FALSE);
Attachment #367641 -
Flags: approval1.9.1? → approval1.9.1+
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•