The default bug view has changed. See this FAQ.

PRBool problem in nsHTMLEditor::EnableExistingStyleSheet

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
Editor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: (dormant account), Assigned: graememcc)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
x86
Linux
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Error: /editor/libeditor/html/nsHTMLEditor.cpp:
 3697 & 3705:   NS_ENSURE_SUCCESS(rv, rv);

http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#3705

See Taras' blog for more info about prbool bugs
http://blog.mozilla.com/tglek/2008/11/07/enabling-prcheck-email-notifications/#respond


bug 432114 is the last mod to that code, but I think the problem was there before.
(Assignee)

Comment 1

8 years ago
Created attachment 367641 [details] [diff] [review]
Fix
[Checkin: Comment 2]
Attachment #367641 - Flags: superreview?(peterv)
Attachment #367641 - Flags: review?(peterv)
Attachment #367641 - Flags: superreview?(peterv)
Attachment #367641 - Flags: superreview+
Attachment #367641 - Flags: review?(peterv)
Attachment #367641 - Flags: review+
Attachment #367641 - Flags: approval1.9.1?
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Comment on attachment 367641 [details] [diff] [review]
Fix
[Checkin: Comment 2]


http://hg.mozilla.org/mozilla-central/rev/3499bad5d5ce
Attachment #367641 - Attachment description: Fix → Fix [Checkin: Comment 2]
Assignee: nobody → graememcc_firefox
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk

Comment 3

8 years ago
Curious, any particular reason for switching to if (NS_FAILED) which doesn't warn in debug builds instead of just using NS_ENSURE_SUCCESS(rv, PR_FALSE);
Attachment #367641 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 367641 [details] [diff] [review]
Fix
[Checkin: Comment 2]

a1.9.1=dbaron
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b37de4254e14
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.