483843 - 3.0.x Major Update dialog list of incompatible updates dialog does not list all incompatible extensions and themes (even those without updates)

Status: RESOLVED DUPLICATE of bug 324121

(Toolkit :: Application Update, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

We've been around this bug before. Since the original has been redesignated for dictionaries, I'm opening a new bug.

I have a Firefox 3.0.7 install with the "Cooliris 1.9.1" extension (https://addons.mozilla.org/en-US/firefox/addon/5579) and the "Noia 2.0 (extreme) 3.61" theme (https://addons.mozilla.org/en-US/firefox/addon/72). Both are incompatible with Firefox 3.1 b3. Neither has an update available to them to make them compatible with 3.1 b3.

When the 3.0.7 user checks for updates and is offered a Major Update, the "show list" button to show incompatible extensions and themes does *not* list either of these two items as being incompatible with the major update.

The first run dialog after 3.1 b3 is installed *does* list them as incompatible. Checking for updates to extensions and themes in the first run does not show an update to either of these is available (and there are no updates). 

After finishing the 3.1 installation, if the Add-ons Manager is examined, both the extension and theme will show up as inactive and incompatible.

So, the 3.0.x Major Update dialog is not properly listing all incompatible extensions and themes, not just failing to list those with compatible updates available.

This was found on OS X 10.5.6.

Comment 1

[Robert Strong (they/them - no direct email)]

Not sure why this bug is different than other bugs. See bug 324121 comment #108
> You could have requested blocking-1.9.0.8/9 and avoided spamming people for all
> the dependent bugs for this.
for what I am referring to.

The original bug Al filed was morph'd because of the above and due to there being two separate issues being reported (e.g. incorrect list of add-ons which is covered by bug 324121 and non managed dictionaries).

Drivers, as inferred above this is the same as bug 324121 and the patch in that bug should be evaluated when determining risk / value. Both the extension manager and software update had to be heavily patched and this bug has existed since the functionality was first introduced back in 1.5.

Comment 2

[Al Billings [:abillings - ex-MoCo]]

This is different because I was informed that the extensions or themes that are not displayed in the list in the major update dialog are those that have updates available which will make them compatible with the update.

Both of the items listed above are incompatible with Firefox 3.1 b3 and have no available updates to make them compatible but they still don't show up on the list in the major update dialog.

This means that users of the extension or theme above (and others) will not find out that they are not compatible with their major update until the first run dialog warns them, which is too late to stop the update from occurring.

Comment 3

[Al Billings [:abillings - ex-MoCo]]

Bug 324121 is about extensions with updates available, differentiating it from this one.

Comment 4

[Robert Strong (they/them - no direct email)]

I assure you... once again... that it is the same bug. There were several issues with the incompatible list that have been around since it was introduced in 1.5 and what you described is another one that was fixed by bug 324121. I was just the lucky pierre that got to fix them.

Comment 5

[Daniel Veditz [:dveditz]]

If it takes 324121 to fix this there's no way we can shoehorn it into a 1.9.0.x release.

Comment 6

[Robert Strong (they/them - no direct email)]

(In reply to comment #5)
> If it takes 324121 to fix this there's no way we can shoehorn it into a 1.9.0.x
> release.
It would require the new interfaces and new interfaces for the modified interfaced for the extensions manager and app update from bug 324121 along with the changes for with those interfaces... e.g. it would be a significant amount of code.

Comment 7

[Robert Strong (they/them - no direct email)]

This only affects Firefox 3.0 (bug 324121 fixed this for Firefox 3.5) and per several previous discussions backporting bug 324121 isn't going to happen so duping this over to the actual bug for this issue.