Password Manager opens a window, not a dialog

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: neil, Assigned: jag+mozilla)

Tracking

({helpwanted, regression})

Trunk
helpwanted, regression
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
When toPasswordManager was originally written, toOpenWindowByType only opened windows, since it hardcoded the window features, although the password manager is really a dialog. Fortunately (or unfortunately, as toOpenWindowByType was enhanced before toPasswordManager was checked in) toOpenWindowByType now supports an optional features parameter, which we can use to make the password manager open with the correct chrome and resizable features.
(Reporter)

Updated

10 years ago
Whiteboard: [good first bug]
(Assignee)

Comment 1

10 years ago
Created attachment 368022 [details] [diff] [review]
Make this be a resizable dialog instead of an app window.

Also fix the type so we can find it if it's already open.
Assignee: nobody → jag
Attachment #368022 - Flags: superreview?(neil)
Attachment #368022 - Flags: review?(neil)
(Reporter)

Updated

10 years ago
Attachment #368022 - Flags: superreview?(neil)
Attachment #368022 - Flags: superreview+
Attachment #368022 - Flags: review?(neil)
Attachment #368022 - Flags: review+
(Reporter)

Comment 2

10 years ago
Comment on attachment 368022 [details] [diff] [review]
Make this be a resizable dialog instead of an app window.

Ah, good catch.

Are you going to remove the chrome feature from our other openDialog calls? ;-)
(Assignee)

Comment 3

10 years ago
It'd make a nice "getting started" bug for someone.

There's so much crap out there. "dialog=yes", "modal=yes" (the "=yes" part is redundant), "all,x,y,z" where x, y, and z are covered by all.
(Assignee)

Comment 4

10 years ago
http://hg.mozilla.org/comm-central/rev/2a1ab3ad5b8f
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.