483960 - Password Manager opens a window, not a dialog

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

When toPasswordManager was originally written, toOpenWindowByType only opened windows, since it hardcoded the window features, although the password manager is really a dialog. Fortunately (or unfortunately, as toOpenWindowByType was enhanced before toPasswordManager was checked in) toOpenWindowByType now supports an optional features parameter, which we can use to make the password manager open with the correct chrome and resizable features.

Comment 1

[jag (Peter Annema)]

Attachment: Make this be a resizable dialog instead of an app window.

Also fix the type so we can find it if it's already open.

Comment 2

[[e-mail]]

Comment on attachment 368022 [details] [diff] [review]
Make this be a resizable dialog instead of an app window.

Ah, good catch.

Are you going to remove the chrome feature from our other openDialog calls? ;-)

Comment 3

[jag (Peter Annema)]

It'd make a nice "getting started" bug for someone.

There's so much crap out there. "dialog=yes", "modal=yes" (the "=yes" part is redundant), "all,x,y,z" where x, y, and z are covered by all.

Comment 4

[jag (Peter Annema)]

http://hg.mozilla.org/comm-central/rev/2a1ab3ad5b8f