Closed
Bug 483977
Opened 15 years ago
Closed 15 years ago
nsCSSScanner: Simplify IsDigit
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: alfredkayser, Assigned: alfredkayser)
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
|
1.79 KB,
patch
|
Details | Diff | Splinter Review |
one could replace
IsDigit{return PRUint32(ch) < 256 && (gLexTable[ch] & IS_DIGIT) != 0;}
with
IsDigit(return (ch>='0' && ch <='9');}
As that won't require a reference to a table and performing a bit operation on
value, just two compares, which is inlined much better.
|
Assignee | |
Comment 1•15 years ago
|
||
Comment on attachment 368005 [details] [diff] [review] Simplify IsDigit r+sr=dbaron
Attachment #368005 -
Flags: superreview+
Attachment #368005 -
Flags: review?(dbaron)
Attachment #368005 -
Flags: review+
|
|
Assignee | |
Updated•15 years ago
|
Flags: wanted1.9.1?
Whiteboard: [checkin needed]
|
||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin needed]
Flags: wanted1.9.1? → wanted1.9.1-
|
||
Comment 3•15 years ago
|
||
Looks like that patch doesn't apply anymore. Also, it should be a proper hg diff.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #368005 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•15 years ago
|
||
This is still a clean patch, and is still valid to be checked in.
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5fda24bc3679
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•