483989 - 3 Mochitest test_2d.*.html run fine but need to check/report success

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Serge Gautherie (:sgautherie)]

(I noticed this on my Windows SeaMonkey/1.9.2 build...)

{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366670.1237376580.14560.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/18 01:57:50
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366174.1237371300.5105.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/18 01:49:34
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237364751.1237377089.15377.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/18 01:25:51

*** 16554 INFO Running /tests/content/canvas/test/test_2d.scaled.html...
*** 16556 INFO Running /tests/content/canvas/test/test_2d.shadow.alpha.1.html...
[...]
*** 16616 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.high.html...
*** 16618 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.low.html...
*** 16620 INFO Running /tests/content/canvas/test/test_2d.shadow.canvas.alpha.html...
}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Add |ok(true, ...);| [Checkin: See comment 5 & 7]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090318
Minefield/3.6a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/6f21cfb3a12d)

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 368016 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 5 & 7]

OK, but shouldn't these tests somehow check for correctness?

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> OK, but shouldn't these tests somehow check for correctness?

That's what I thought too, even wondered if they should rather be reftests.
Yet, I know too little about how these canvas tests are supposed to work/error...

You'd better comment on bug 446534 (or a new one).
All I could do here is mark them as 'todo' instead, if you prefer ?

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yeah, I think just mark them todo for now.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 368016 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 5 & 7]


http://hg.mozilla.org/mozilla-central/rev/ec12bb073ec0
Av1, with comment 4 suggestion(s).

Comment 6

[Serge Gautherie (:sgautherie)]

PS: If someone wants to fix the todos in a near future, feel free to reopen this bug.  (Otherwise, file a follow-up bug.)

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 368016 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 5 & 7]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4417ade14dd6
(Av1a) Add |todo(false, ...);| !

Comment 8

[Serge Gautherie (:sgautherie)]

V.Fixed:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237543426.1237550001.8047.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/20 03:03:46

*** 16556 INFO Running /tests/content/canvas/test/test_2d.scaled.html...
*** 16557 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/test_2d.scaled.html | test completed successfully
...
*** 16619 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.high.html...
*** 16620 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/test_2d.shadow.blur.high.html | test completed successfully
*** 16622 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.low.html...
*** 16623 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/test_2d.shadow.blur.low.html | test completed successfully
}