Closed Bug 483989 Opened 12 years ago Closed 12 years ago

3 Mochitest test_2d.*.html run fine but need to check/report success

Categories

(Core :: Canvas: 2D, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])

Attachments

(1 file)

(I noticed this on my Windows SeaMonkey/1.9.2 build...)

{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366670.1237376580.14560.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/18 01:57:50
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366174.1237371300.5105.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/18 01:49:34
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237364751.1237377089.15377.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/18 01:25:51

*** 16554 INFO Running /tests/content/canvas/test/test_2d.scaled.html...
*** 16556 INFO Running /tests/content/canvas/test/test_2d.shadow.alpha.1.html...
[...]
*** 16616 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.high.html...
*** 16618 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.low.html...
*** 16620 INFO Running /tests/content/canvas/test/test_2d.shadow.canvas.alpha.html...
}
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090318
Minefield/3.6a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/6f21cfb3a12d)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #368016 - Flags: review?(vladimir)
Comment on attachment 368016 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 5 & 7]

OK, but shouldn't these tests somehow check for correctness?
Attachment #368016 - Flags: review?(vladimir) → review+
(In reply to comment #2)
> OK, but shouldn't these tests somehow check for correctness?

That's what I thought too, even wondered if they should rather be reftests.
Yet, I know too little about how these canvas tests are supposed to work/error...

You'd better comment on bug 446534 (or a new one).
All I could do here is mark them as 'todo' instead, if you prefer ?
Yeah, I think just mark them todo for now.
Comment on attachment 368016 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 5 & 7]


http://hg.mozilla.org/mozilla-central/rev/ec12bb073ec0
Av1, with comment 4 suggestion(s).
Attachment #368016 - Attachment description: (Av1) Add |ok(true, ...);| → (Av1) Add |ok(true, ...);| [Checkin: See comment 5]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
PS: If someone wants to fix the todos in a near future, feel free to reopen this bug.  (Otherwise, file a follow-up bug.)
Comment on attachment 368016 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: See comment 5 & 7]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4417ade14dd6
(Av1a) Add |todo(false, ...);| !
Attachment #368016 - Attachment description: (Av1) Add |ok(true, ...);| [Checkin: See comment 5] → (Av1) Add |ok(true, ...);| [Checkin: See comment 5 & 7]
Keywords: fixed1.9.1
Whiteboard: [fixed1.9.1b4]
V.Fixed:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237543426.1237550001.8047.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/20 03:03:46

*** 16556 INFO Running /tests/content/canvas/test/test_2d.scaled.html...
*** 16557 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/test_2d.scaled.html | test completed successfully
...
*** 16619 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.high.html...
*** 16620 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/test_2d.shadow.blur.high.html | test completed successfully
*** 16622 INFO Running /tests/content/canvas/test/test_2d.shadow.blur.low.html...
*** 16623 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/test_2d.shadow.blur.low.html | test completed successfully
}
Status: RESOLVED → VERIFIED
No longer blocks: 483407
Depends on: 483407
You need to log in before you can comment on or make changes to this bug.