484006 - Frequent "Mailbox does not exist" warnings on IMAP account with saved search folder due to autosync

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Mark Banner (:standard8)]

Now we've got the warnings/alerts hooked up to the activity manager, I'm seeing a message:

"The current command did no succeed. The mail server responded: Mailbox does not exist, or must be subscribed to.."

Looking at an IMAP log, this is quite clearly trying to access a saved search folder on an imap server (probably during autosync, especially as David Bienvenu told me it was likely to happen). From the log:

-1334685696[1dacf6c0]: d91e00:hostname:A:ProcessCurrentURL: entering
-1334685696[1dacf6c0]: d91e00:hostname:A:ProcessCurrentURL:imap://hostname/folderstatus%3E.testsaved:  = currentUrl
-1334685696[1dacf6c0]: d91e00:hostname:A:SendData: 34 STATUS "INBOX.testsaved" (UIDNEXT MESSAGES UNSEEN RECENT)
-1334685696[1dacf6c0]: ReadNextLine [stream=1dac06dc nb=57 needmore=0]
-1334685696[1dacf6c0]: d91e00:hostname:A:CreateNewLineFromSocket: 34 NO Mailbox does not exist, or must be subscribed to.
-1337147392[1d2ce740]: e2ea00:hostname:S-INBOX:SendData: DONE

testsaved is my saved search folder.

Comment 1

[David :Bienvenu]

taking

Comment 2

[David :Bienvenu]

Attachment: proposed fix

while debugging autosync, I see how annoying this is - this should fix it for autosync, and for updating all non-inbox folders on biff...

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 369401 [details] [diff] [review]
proposed fix

>   if ((forceAllFolders &&
>-    !(flags & (nsMsgFolderFlags::Inbox | nsMsgFolderFlags::Trash | nsMsgFolderFlags::Junk | nsMsgFolderFlags::ImapNoselect)))
>+    !(flags & (nsMsgFolderFlags::Inbox | nsMsgFolderFlags::Trash | nsMsgFolderFlags::Junk |
>+               nsMsgFolderFlags::ImapNoselect | nsMsgFolderFlags::Virtual)))
>     || (flags & nsMsgFolderFlags::CheckNew))
>   {
>     // Get new messages for this folder.

Whilst you're here, could you fix this up to be the more conventional format:

if ((forceAllFolders &&
     !(flags & (nsMsgFolderFlags::Inbox | nsMsgFolderFlags::Trash | nsMsgFolderFlags::Junk | nsMsgFolderFlags::ImapNoselect)))
     !(flags & (nsMsgFolderFlags::Inbox | nsMsgFolderFlags::Trash | nsMsgFolderFlags::Junk |
               nsMsgFolderFlags::ImapNoselect | nsMsgFolderFlags::Virtual))) ||
    (flags & nsMsgFolderFlags::CheckNew))

So that we have the starts of the lines aligned just inside the brackets that they apply to.

Comment 4

[David :Bienvenu]

fix checked in, with alignment fixed.