Closed Bug 484083 Opened 15 years ago Closed 15 years ago

Should load TruType Collection file too

Categories

(Core :: Graphics, defect)

ARM
Windows Mobile 6 Professional
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.8.0.4) Gecko/20060508 Firefox/3.0
Build Identifier: 

TruType Collection <http://www.microsoft.com/typography/otspec/otff.htm> should be loaded same as ttf and otf.

Reproducible: Always
Attached patch Patch (obsolete) — Splinter Review
Attachment #368134 - Flags: review?(bugmail)
OS: Other → Windows Mobile 6 Professional
Hardware: Other → ARM
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #368134 - Flags: review?(vladimir)
Attachment #368134 - Flags: review?(bugmail)
Attachment #368134 - Flags: review+
Comment on attachment 368134 [details] [diff] [review]
Patch

please bump the size of the fontPatterns array from 4 to 6.  Otherwise this looks good.

Requesting additional review from Vlad (gfx owner)
Attachment #368134 - Flags: review?(vladimir) → review?(jdaggett)
Attached patch update patch (obsolete) — Splinter Review
Widen fontPatterns size.
Thank you, Brad.
Attachment #368134 - Attachment is obsolete: true
Attachment #368743 - Flags: superreview?(jdaggett)
Attachment #368743 - Flags: review+
Attachment #368134 - Flags: review?(jdaggett)
Adapt to the latest trunk.
Attachment #368743 - Attachment is obsolete: true
Attachment #372537 - Flags: superreview?(jdaggett)
Attachment #372537 - Flags: review+
Attachment #368743 - Flags: superreview?(jdaggett)
Comment on attachment 372537 [details] [diff] [review]
Update patch
[Checkin: Comment 7]

Looks fine, sorry for the delay.
Attachment #372537 - Flags: superreview?(jdaggett) → superreview+
Thank you!
Keywords: checkin-needed
Assignee: nobody → ikezoe
Comment on attachment 372537 [details] [diff] [review]
Update patch
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/e2bf0c7914c8
Attachment #372537 - Attachment description: Update patch → Update patch [Checkin: Comment 7]
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: