484122 - geolocation timeout due to string change

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

when strings were change:

http://hg.mozilla.org/mozilla-central/rev/c0eea14622a6

our mochitest failed:

Unknown Error: command finished with exit code: 2
*** 41419 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/geolocation/test_allowCurrent.html | Clicked "Exact Location (within 10 feet)" button
buildbot.slave.commands.TimeoutError: command timed out: 300 seconds without output, killing pid 30879



This is due to the test cases relying on the actual text of the string in the buttons of the notification info bar.  This is pretty weak, but other mochitest do the same thing.

This is a quick fix.  we should actually not rely on the text of the buttons, but rather their id or something that doesn't change.

Comment 1

[Serge Gautherie (:sgautherie)]

What is the status here ?

Comment 2

[Doug Turner (:dougt)]

this landed, and then we stop using strings to id the particular button.