Closed
Bug 484127
Opened 16 years ago
Closed 16 years ago
Move browser_scope.js into browser/
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])
Attachments
(1 file, 1 obsolete file)
2.56 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
browser_scope.js tests to make sure the current JS scope is in browser.js, but it is really Firefox specific. Other apps will have different testing scopes. Fennec, for example, uses a browser.js scope, but a different one than Firefox. The Firefox tests actually fail when run in Fennec. So we will move the current browser_scope.js to browser/ and make a slightly different browser_scope.js for Fennec. Not sure if Seamonkey needs this or not.
Assignee | ||
Comment 1•16 years ago
|
||
This moves browser_scope.js into browser/base/content/test
Assignee: nobody → mark.finkle
Attachment #368186 -
Flags: review?(gavin.sharp)
Comment 2•16 years ago
|
||
Comment on attachment 368186 [details] [diff] [review] patch Perhaps we should leave a test in testing/mochitest/tests/browser/ that simply tests for chrome privileges?
Attachment #368186 -
Flags: review?(gavin.sharp) → review+
Comment 3•16 years ago
|
||
Actually, the test checks that gBrowser and getBrowser() both work and return the same. I guess a number of extension might depend on one or the other, and SeaMonkey reports success as it provides both in the browser window. But it's probably correct to have the test in browser/ as it's actually very browser-specific things to have that var and that function defined.
Assignee | ||
Comment 4•16 years ago
|
||
same as the previous patch, but this one adds a simple test for script privileges
Attachment #368186 -
Attachment is obsolete: true
Attachment #368248 -
Flags: review?(gavin.sharp)
Updated•16 years ago
|
Attachment #368248 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 5•16 years ago
|
||
Comment on attachment 368248 [details] [diff] [review] patch 2 - with a basic privileges test [Checkin: Comment 5 & 6] http://hg.mozilla.org/mozilla-central/rev/9561a35a9e79
Attachment #368248 -
Attachment description: patch 2 - with a basic privileges test → patch 2 - with a basic privileges test
[Checkin: Comment 5]
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Comment 6•16 years ago
|
||
Comment on attachment 368248 [details] [diff] [review] patch 2 - with a basic privileges test [Checkin: Comment 5 & 6] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1b507212507c
Attachment #368248 -
Attachment description: patch 2 - with a basic privileges test
[Checkin: Comment 5] → patch 2 - with a basic privileges test
[Checkin: Comment 5 & 6]
Updated•16 years ago
|
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 1.9.1 landing] → [fixed1.9.1b4]
Comment 7•16 years ago
|
||
(In reply to comment #6) > (From update of attachment 368248 [details] [diff] [review]) > > http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1b507212507c Fwiw, this was after fixing context for { patching file browser/base/content/test/Makefile.in Hunk #1 FAILED at 93 1 out of 1 hunks FAILED }
Updated•7 years ago
|
Component: BrowserTest → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•