484234 - need to show the urlbar while the page is loading

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

see discussion in bug 483425

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Proposed patch

I am not convinced what expects exactly but this patch makes things better.

Comment 2

[Ben Combee (:bcombee)]

I like the direction of the patch.  I'd add internal function names in the new methods for Tab since we're trying to go in that direction, but the code seems valid.  I'd also like a little explanation, perhaps in comments, about why the firstPageLoaded behavior exists.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Add comments.

Add some comments about firstPageLoaded behaviour, but I could't understand about internal function names.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 381381 [details] [diff] [review]
Add comments.

I think we want to show the URLBar for any navigation, not just the first.

Bug 483425 is about panning to the top before we actually move away from the current page.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

(In reply to comment #4)
> (From update of attachment 381381 [details] [diff] [review])
> I think we want to show the URLBar for any navigation, not just the first.

You mean the URLBar is shown after each page is loaded?

Comment 6

[Ben Combee (:bcombee)]

Agreed with Mark -- I want to see the URL bar show up whenever we navigate to a
new page, otherwise there's no good indicator of where you're going to.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Revised patch

Persist the URLBar after each page is loaded.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 381401 [details] [diff] [review]
Revised patch

This patch does give the desired behavior.

We still have other issues around page navigation, but those are in other bugs.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/8b2dfdb54f4d

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre