need to show the urlbar while the page is loading

VERIFIED FIXED

Status

Fennec Graveyard
General
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: (dormant account), Assigned: hiro)

Tracking

(Blocks: 1 bug)

Dependency tree / graph

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

9 years ago
see discussion in bug 483425
tracking-fennec: --- → ?

Updated

9 years ago
tracking-fennec: ? → 1.0+
(Assignee)

Comment 1

9 years ago
Created attachment 381167 [details] [diff] [review]
Proposed patch

I am not convinced what expects exactly but this patch makes things better.
Assignee: nobody → ikezoe
Status: NEW → ASSIGNED
Attachment #381167 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #381167 - Flags: review? → review?(mark.finkle)
I like the direction of the patch.  I'd add internal function names in the new methods for Tab since we're trying to go in that direction, but the code seems valid.  I'd also like a little explanation, perhaps in comments, about why the firstPageLoaded behavior exists.
(Assignee)

Comment 3

9 years ago
Created attachment 381381 [details] [diff] [review]
Add comments.

Add some comments about firstPageLoaded behaviour, but I could't understand about internal function names.
Attachment #381167 - Attachment is obsolete: true
Attachment #381381 - Flags: review?(combee)
Attachment #381167 - Flags: review?(mark.finkle)
Attachment #381381 - Flags: review?(combee) → review-
Comment on attachment 381381 [details] [diff] [review]
Add comments.

I think we want to show the URLBar for any navigation, not just the first.

Bug 483425 is about panning to the top before we actually move away from the current page.
(Assignee)

Comment 5

9 years ago
(In reply to comment #4)
> (From update of attachment 381381 [details] [diff] [review])
> I think we want to show the URLBar for any navigation, not just the first.

You mean the URLBar is shown after each page is loaded?
Agreed with Mark -- I want to see the URL bar show up whenever we navigate to a
new page, otherwise there's no good indicator of where you're going to.
(Assignee)

Comment 7

9 years ago
Created attachment 381401 [details] [diff] [review]
Revised patch

Persist the URLBar after each page is loaded.
Attachment #381381 - Attachment is obsolete: true
Attachment #381401 - Flags: review?(mark.finkle)
Comment on attachment 381401 [details] [diff] [review]
Revised patch

This patch does give the desired behavior.

We still have other issues around page navigation, but those are in other bugs.
Attachment #381401 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/8b2dfdb54f4d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.