484238 - no click event generated when div is clicked

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Martin Honnen]

Attachment: test case

In the test case I am going to upload, when you click the yellow bar which is part of the div with id "rbarRuler" with the mouse, Firefox 3.1 beta 3 as well as a trunk nightly (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090319 Minefield/3.6a1pre) does not fire a click event.

Firefox 3.0 however does, as do other browsers like IE 7 or Opera 9.6.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Regression range would be great.

Comment 2

[Martin Honnen]

The problem was originally reported in the German newsgroup de.comp.lang.javascript with the test case http://brain4.de/test/dcljs/events/ff3.1b3-testcase.html. The reporter there says that the problem happens with Firefox 3.1 beta 3 and all previous 3.1 betas.

Comment 3

[Nochum Sossonko [:Natch]]

Regression Range:

works: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a2pre) Gecko/20080814041610 Minefield/3.1a2pre

fails: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a2pre) Gecko/20080815064214 Minefield/3.1a2pre

pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-08-14&enddate=2008-08-15

Comment 4

[j.j.]

Attachment: simple testcase

overflow:auto on the inner div is guilty

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

The regression range missed few hours. This is a regression from
bug 262306.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

One option is to back out bug 262306 (and bug 458418 which was also a regression from bug 262306).

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

I don't understand why bug 262306 moved mouse capturing to happen before the following:
if (frameselection->GetDisplaySelection() == nsISelectionController::SELECTION_OFF)
    return NS_OK;//nothing to do we cannot affect selection from here

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #7)
er, nm that comment.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: backout bug 262306 and bug 458418

This is IMO significantly worse bug than bug 262306, so we should back out bug 
262306 and bug 458418 and reopen bug 262306. That one is more like wanted1.9.1, not blocking1.9.1. IMHO.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 369727 [details] [diff] [review]
backout bug 262306 and bug 458418 

OK

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/772968cca2c1

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED using testcases attached on builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090721
Minefield/3.6a1pre ID:20090721044139

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.1pre) Gecko/20090720
Shiretoko/3.5.1pre ID:20090720042942