Closed Bug 484288 Opened 12 years ago Closed 6 years ago

Moving non-Default Search Engines in Manager activates "Restore Default" button


(Firefox :: Search, defect)

3.5 Branch
Not set





(Reporter: aakashd, Unassigned)



(3 files)

Build ID: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3

The screenshots attached to the bug describe the behavior, but basically following the steps:

1. Add two or more search engines to firefox
2. Go to the "Manage Search Engines" Manager.
3. Move the newly added search engines in a way that only affects those that are not defaults.

Note: this bug is taking into consideration that the default search engines are listed in their original form.

Actual Results:

The "Restore Defaults" button is activated.

Expected Results:

The "Restore Defaults" button should not be activated unless changes are made to the default added search engines.
That happens for all OS/Platforms.
OS: Linux → All
Hardware: x86 → All
Henrik: you don't need to CC me on Search bugs, I watch the entire component.

Restoring default engines also restore their natural order, so we enable the button unconditionally (i.e. call showRestoreDefaults(true)) from both the up/down button handlers and the drag handler, in engineManager.js. We could add code to check whether the move impacted one of the default engines, but I'm not sure it's worth the trouble.
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.