484320 - (CVE-2009-1044) XUL <tree> _moveToEdgeShift garbage-collection exploit (zdi-can-465)

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[Daniel Veditz [:dveditz]]

Placeholder for Pwn2Own bug found in Firefox at CanSecWest 2009

Comment 1

[Daniel Veditz [:dveditz]]

http://crash-stats.mozilla.com/report/index/8891b794-7cbe-4ace-85b9-48d602090320

Comment 3

[Daniel Veditz [:dveditz]]

jst said to start with Neil. Since this is a high profile bug (Firefox cracked during a public hacking contest) we need to focus on it. If we had a fix I'd like to shoehorn it into 1.9.0.8 even though we're past codefreeze (April release) but May's 1.9.0.9 is more realistic. Needs to make 3.5b4.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Windows and OSX stacks look quite different :/

Does this crash on trunk/1.9.1?
If not, my guess is that bug 430214 fixed this.
Especially this https://bugzilla.mozilla.org/attachment.cgi?id=348637&action=edit
It changed nsTreeSelection::FireOnSelectHandler to asynchronous.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #4)
> Does this crash on trunk/1.9.1?
I was told it does crash, so something else then...

Comment 6

[Daniel Veditz [:dveditz]]

Here's yet a different Windows crash, in Shiretoko rather than 3.0.7
bp-bccadf08-a8f0-4a6f-8374-47c802090323

what does nsTextServicesDocument::InitWithEditor have to do with this testcase?

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

This sounds like memory stomping somewhere. valgrind might shed some light.

Comment 8

[Daniel Veditz [:dveditz]]

Attachment: safer starting point

Here's a safer starting point. The guts of the testcase are still in the poc.zip, but this copy of hold.html has the shellcode replaced with %u4141...

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, need to fix this for the reasons stated above. Neil: are you the right dude to be looking at this?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Could someone please test this on non-linux.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

I haven't yet checked if timer code should be actually fixed.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

I tested this on 1.9.1 / 64bit linux / debug build

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #11)
> I haven't yet checked if timer code should be actually fixed.
But for 1.9.0 the patch might be the safest fix - shouldn't cause regressions.

Comment 14

[Daniel Veditz [:dveditz]]

Note that I never got the PoC to crash in a debug build so the patch will have to be verified in an opt build.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 368977 [details] [diff] [review]
patch

So, InitWithFuncCallback is used, passing this is unsafe *unless*
timer is canceled before deleting this.

Comment 16

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 368977 [details] [diff] [review]
patch

This makes sense. Good catch!

Comment 17

[Daniel Veditz [:dveditz]]

Comment on attachment 368977 [details] [diff] [review]
patch

r=dveditz

Tested in opt builds and this patch stops the mac crashes I was seeing (I never got a debug build to crash). Since I was seeing completely different stacks on windows I'd like to verify this there as well.

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 368977 [details] [diff] [review]
patch

Does this have to go in on trunk and branch at the same time, or can we bake it there a bit first? Either way, it's a blocker, so doesn't need a191.

Comment 19

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/6955c8360d08
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/60caf43ff9c2

This does still need verification on windows.

Comment 20

[Olli Pettay [:smaug][[e-mail]]]

The patch does fix the crash also on 1.9.0 (tested on linux).

Comment 21

[Martijn Wargers (dead)]

The patch seems to fix the crash for me in my trunk debug build on windows XP.

Comment 22

[Daniel Veditz [:dveditz]]

Comment on attachment 368977 [details] [diff] [review]
patch

Approved for 1.9.0.8, a=dveditz for release-drivers

Can you land this ASAP? we're well beyond code-freeze for 1.9.0.8

Comment 23

[Olli Pettay [:smaug][[e-mail]]]

Checking in layout/xul/base/src/tree/src/nsTreeSelection.cpp;
/cvsroot/mozilla/layout/xul/base/src/tree/src/nsTreeSelection.cpp,v  <--  nsTreeSelection.cpp
new revision: 1.59; previous revision: 1.58
done

Comment 24

[Daniel Veditz [:dveditz]]

Stops the crash on windows for me as well (tested shiretoko tinderbox build).

Comment 25

[Samuel Sidler (old account; do not CC)]

Olli: Does this bug affect 1.8? We're taking it in a firedrilled Firefox 3.0.8, so if so, we'll want to get a patch ready for the distros to take.

Comment 26

[Olli Pettay [:smaug][[e-mail]]]

I can't reproduce the crash on 1.8.1, but I don't know why.
The code is the same.

The patch applies to 1.8.1 too (just need to use --fuzz=3)

Comment 27

[Olli Pettay [:smaug][[e-mail]]]

Ah, 1.8.1 doesn't seem to have bug 362680. So reproducing would need some
changes to the testcase.

Comment 28

[Christopher Aillon (sabbatical, not receiving bugmail)]

1.8.0 is in the same boat as above.  patch applies with fuzz=3, but testcase doesn't work

Comment 29

[Johnathan Nightingale [:johnath]]

Should this have a crashtest?

Comment 30

[Olli Pettay [:smaug][[e-mail]]]

Not yet, IMO. As far as I know the testcase is not public yet.

Comment 31

[Josh Bressers]

This is CVE-2009-1044

Comment 32

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #31)
> This is CVE-2009-1044
But the testcase isn't public, right?

Comment 33

[Josh Bressers]

No, MITRE assigned this based only off of the announcement from CanSecWest.  If you look at the CVE id information:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-1044

There is nothing of consequence there.  It's just a placeholder.

Comment 34

[juan becerra [:juanb]]

Verified using: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.8) Gecko/2009032608 Firefox/3.0.8

Also verified with Fx308 on Ubuntu 8.10 and Windows XP and Vista.

Mac Fx307 crashed with the test case.

Fx307 did not crash on Linux nor Windows(xp/vista) VMs for me. Fx307 did crash on a windows installation running on hardware, however.

Comment 35

[Daniel Veditz [:dveditz]]

Although the exploit doesn't affect the 1.8 branch because it uses functionality that doesn't exist there, we should take this small patch just in case there's another way to end up with a dangling selection timer.

Comment 36

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.0.9 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.9pre) Gecko/2009040206 GranParadiso/3.0.9pre (.NET CLR 3.5.30729) and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.9pre) Gecko/2009040204 GranParadiso/3.0.9pre.

Verified for 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090402 Shiretoko/3.5b4pre.

Comment 37

[Alexander Sack]

Comment on attachment 368977 [details] [diff] [review]
patch

code is the same, so it seems it makes sense to take this.

Comment 38

[Alexander Sack]

Comment on attachment 368977 [details] [diff] [review]
patch

a=asac for 1.8.0

Comment 39

[Daniel Veditz [:dveditz]]

fix checked into the 1.8.1 branch
Checking in layout/xul/base/src/tree/src/nsTreeSelection.cpp;
/cvsroot/mozilla/layout/xul/base/src/tree/src/nsTreeSelection.cpp,v  <--  nsTreeSelection.cpp
new revision: 1.47.4.1; previous revision: 1.47