Closed Bug 484374 Opened 14 years ago Closed 14 years ago

groupbox.collapsable needs the adjustment of margin/padding

Categories

(Firefox :: Page Info Window, defect)

Product:
Firefox
Component:
Page Info Window
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3.5b4

People

(Reporter: spitfire.kuden, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.9.1, regression, Whiteboard: [polish-easy][polish-visual][polish-p3])

Attachments

(3 files, 2 obsolete files)

Tools -> Page Info -> General
23.73 KB, image/png
Details
patch rev2
1.10 KB, patch
dao
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
screenshots for comparison
214.21 KB, image/png
Details 
Screenshot
Whiteboard: [polish-easy][polish-visual]
Attached patch patch rev1 (obsolete) — — Splinter Review 
Assignee: nobody → robert.bugzilla

        Attachment #369019 -
        Flags: review?(dao)

    
    

    
  

      
      
      
      

        Attached image
          
        screenshot comparison (obsolete)
        — 
      

    


  

    
    

    
  
(In reply to comment #1)
> Created an attachment (id=369019) [details]
> patch rev1

This looks good. 

Additionally, I think that here is also necessary. 
(Because .caption-text has "margin: 0 2px".)

 /* General Tab */
 groupbox.collapsable caption .caption-icon { 
   width: 9px;
   height: 9px;
   background-repeat: no-repeat;
   background-position: center;
-  -moz-margin-start: 1px;
+  -moz-margin-start: 2px;
   -moz-margin-end: 3px;
   background-image: url("chrome://global/skin/tree/twisty-open.png");
 }

        Attachment #369019 -
        Attachment is obsolete: true

        Attachment #369019 -
        Flags: review?(dao)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch rev2
        — 
          — Splinter Review
      

    


  
Thanks Kuden for catching that.

This should make all of the elements line up in the same way as they did previously

        Attachment #369335 -
        Flags: review?(dao)

    
    

    
  


  

        Attachment #369020 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 369336 [details]
screenshots for comparison

The margin between the image and the caption is slightly less in the collapsed state but I think that is an improvement

        Attachment #369335 -
        Flags: review?(dao) → review+

    
    

    
  
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/6d6ffd1f9843
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 369335 [details] [diff] [review]
patch rev2

Drivers, this fixes the collapsible groupbox in page info (see screenshots for reference)

        Attachment #369335 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 369335 [details] [diff] [review]
patch rev2

a191=beltzner

        Attachment #369335 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7ae811884223
Keywords: fixed1.9.1
Target Milestone: --- → Firefox 3.5b4

    
    

    
  
This bug's priority relative to the set of other polish bugs is:
P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.
Whiteboard: [polish-easy][polish-visual] → [polish-easy][polish-visual][polish-p3]

          You need to log in
          before you can comment on or make changes to this bug.