484374 - groupbox.collapsable needs the adjustment of margin/padding

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: Tools -> Page Info -> General

Screenshot

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: screenshot comparison

Comment 3

[AKIHIRO Misaki (a.k.a Kuden)]

(In reply to comment #1)
> Created an attachment (id=369019) [details]
> patch rev1

This looks good. 

Additionally, I think that here is also necessary. 
(Because .caption-text has "margin: 0 2px".)

 /* General Tab */
 groupbox.collapsable caption .caption-icon { 
   width: 9px;
   height: 9px;
   background-repeat: no-repeat;
   background-position: center;
-  -moz-margin-start: 1px;
+  -moz-margin-start: 2px;
   -moz-margin-end: 3px;
   background-image: url("chrome://global/skin/tree/twisty-open.png");
 }

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Thanks Kuden for catching that.

This should make all of the elements line up in the same way as they did previously

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: screenshots for comparison

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 369336 [details]
screenshots for comparison

The margin between the image and the caption is slightly less in the collapsed state but I think that is an improvement

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/6d6ffd1f9843

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 369335 [details] [diff] [review]
patch rev2

Drivers, this fixes the collapsible groupbox in page info (see screenshots for reference)

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 369335 [details] [diff] [review]
patch rev2

a191=beltzner

Comment 10

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7ae811884223

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.