484440 - Green Download Firefox button doesn't show up using Windows 98

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Using Windows 98, the green Download Firefox button doesn't show up on:

https://www-trunk.stage.mozilla.com/en-US
https://www-trunk.stage.mozilla.com/en-US/firefox/

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 2

[Steven Garrity [:sgarrity]]

This appears to be a side-effect of the AlphaImageLoader() filter we're using to hack in a transparent PNG for the download button in Internet Explorer 6. I've been considering removing this hack for a while as it has a non-negligible memory/performance hit on the client side anyhow.

IE 7/8 support full color alpha transparent PNGs, so it's just IE6 we're worried about here. I'm going to mock up a slightly different variation of the download button that doesn't rely on such a heavy shadow and that might work with a 256 color PNG. We could show this to IE6 users only with a CSS hack.

Comment 3

[Steven Garrity [:sgarrity]]

Attachment: Mockup of simplified buttons for IE6

As suggested in comment #2, I've created a mockup of a simpler version of the download buttons that I propose we uses for IE6 (and only IE6, as IE7 and IE8 can handle the current button fine).

The primary difference in the buttons is that the shadow is neither transparent, nor feathered. In the Firefox-page version, the Firefox logo is smaller and contained inside the green button rather than bleeding out over the edge. It doesn't look as good, but eliminates the need for a full-color transparent PNG since the logo-shadow is contained on the button.

John, are these acceptable for IE6 users, or is it too much of a uglification?

Comment 4

[Samuel Sidler (old account; do not CC)]

(In reply to comment #0)
> Using Windows 98, the green Download Firefox button doesn't show up on:

If we make the download button show on Windows 98, let's make sure it's not Firefox 3, which isn't supported on that OS...

Comment 5

[Steven Garrity [:sgarrity]]

(In reply to comment #4)
> If we make the download button show on Windows 98, let's make sure it's not
> Firefox 3, which isn't supported on that OS...

Good point - though I think that is really a separate issue (and should probably be a separate bug).

Comment 6

[Samuel Sidler (old account; do not CC)]

Yeah. Probably one that's already filed even (bug 439792). :)

Comment 7

[John Slater]

Comment on attachment 370003 [details]
Mockup of simplified buttons for IE6

This works for me...thanks Steven.

Comment 8

[Steven Garrity [:sgarrity]]

Ok, I've got the new buttons in place for IE6. The files affected are:

 img/tignish/firefox/download-button-primary-ie.png
 img/tignish/home/download-button-ie.png
 style/tignish/content.css
 style/tignish/firefox.css

After testing on stage, this can be pushed to production.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot (tested on www-trunk.stage.mozilla.com)

Looking good!

Comment 10

[John Slater]

Just pushed the files live through Kubla...should be on the site soon.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot on production

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

I'll have to file a bug about the missing "Firefox 3.5" logo for Windows 98, I guess, but *this* bug is fixed :-)

Verified.