Closed Bug 484606 Opened 16 years ago Closed 16 years ago

TM: [arm] fix calling convention

Categories

(Core :: JavaScript Engine, defect)

ARM
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

References

Details

Attachments

(1 file)

There was a bug in the current asm_call impl; under EABI, doubles weren't being 64-bit aligned when placed on the stack. This was causing a crash in the last mandelbrot test. The tamarin arm nj doesn't have this bug, though their asm_call is different than this still. With this we pass the tests introduced in bug 484599.
Attachment #368733 - Flags: review?(graydon)
Attachment #368733 - Flags: review?(graydon) → review+
Comment on attachment 368733 [details] [diff] [review] fix call convention Commit without the commented-out fprintfs, otherwise looks ok.
Checked in as 2466d9c9c6e9.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: