484648 - Port Bug 483330 (Session restore flushes layout on save; affects page performance) to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: ported patch [Checkin: Comment 4]

Description From  Boris Zbarsky:

When session restore saves data, it saves scroll positions.  It seems to use
the scrollX and scrollY properties on content windows to do that. 
Unfortunately, those don't just read back the scroll position: they flush
layout and _then_ return the resulting scroll position.  For session restore
that seems unnecessary: if the scroll position will change after reflow, we'll
just get called again.  And the current setup means that if you take a long
page and trigger an interruptible reflow and then scroll during it, then after
3 seconds you get a non-interruptible flush and your browser freezes up for a
while until that's done.

We should probably just have an nsIDOMWindowUtils API for doing this without
flushing.

Comment 1

[Misak Khachatryan]

bug 483634 actually block this one

Comment 2

[[e-mail]]

Comment on attachment 368778 [details] [diff] [review]
ported patch
[Checkin: Comment 4]

>+    let domWindowUtils = aContent.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
>+                                 .getInterface(Components.interfaces.nsIDOMWindowUtils);
>+    let scrollX = {}, scrollY = {};
Nit: var

r+sr=me if getScrollXY lands on 1.9.1

Comment 3

[Misak Khachatryan]

Bug 483634 lands on 1.9.1, we can check this in.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 368778 [details] [diff] [review]
ported patch
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/b2aeb4a8c800