Closed Bug 484648 Opened 12 years ago Closed 12 years ago

Port Bug 483330 (Session restore flushes layout on save; affects page performance) to SeaMonkey

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file)

Description From  Boris Zbarsky:

When session restore saves data, it saves scroll positions.  It seems to use
the scrollX and scrollY properties on content windows to do that. 
Unfortunately, those don't just read back the scroll position: they flush
layout and _then_ return the resulting scroll position.  For session restore
that seems unnecessary: if the scroll position will change after reflow, we'll
just get called again.  And the current setup means that if you take a long
page and trigger an interruptible reflow and then scroll during it, then after
3 seconds you get a non-interruptible flush and your browser freezes up for a
while until that's done.

We should probably just have an nsIDOMWindowUtils API for doing this without
flushing.
Attachment #368778 - Flags: superreview?(neil)
Attachment #368778 - Flags: review?(neil)
bug 483634 actually block this one
Depends on: 483634
Attachment #368778 - Flags: superreview?(neil)
Attachment #368778 - Flags: superreview+
Attachment #368778 - Flags: review?(neil)
Attachment #368778 - Flags: review+
Comment on attachment 368778 [details] [diff] [review]
ported patch
[Checkin: Comment 4]

>+    let domWindowUtils = aContent.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
>+                                 .getInterface(Components.interfaces.nsIDOMWindowUtils);
>+    let scrollX = {}, scrollY = {};
Nit: var

r+sr=me if getScrollXY lands on 1.9.1
Bug 483634 lands on 1.9.1, we can check this in.
Keywords: checkin-needed
Comment on attachment 368778 [details] [diff] [review]
ported patch
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/b2aeb4a8c800
Attachment #368778 - Attachment description: ported patch → ported patch [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.