Closed Bug 485012 Opened 15 years ago Closed 15 years ago

[FIX]Allow passing charset to CSSLoader->LoadSheet()

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bjarne, Assigned: bzbarsky)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Proposed fix
16.59 KB, patch
peterv
: review+
peterv
: superreview+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
See bug #457809#c16

It should be possible to pass the charset to CSSLoader->LoadSheet()
Blocks: 457810
Attached patch Proposed fix — — Splinter Review 
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED

        Attachment #371677 -
        Flags: superreview?(peterv)

        Attachment #371677 -
        Flags: review?(peterv)

    
    

    
  
Bumping severity; I didn't make this clear in bug 457809, but the bug can cause preloading to screw up webpages.  See the reftest in the patch for an example.  It fails without this patch.
Severity: minor → major
Summary: Allow passing charset to CSSLoader->LoadSheet() → [FIX]Allow passing charset to CSSLoader->LoadSheet()

        Attachment #371677 -
        Flags: superreview?(peterv)

        Attachment #371677 -
        Flags: superreview+

        Attachment #371677 -
        Flags: review?(peterv)

        Attachment #371677 -
        Flags: review+

    
    

    
  
Comment on attachment 371677 [details] [diff] [review]
Proposed fix

Almost forgot, new IID for nsICSSLoader?

    
  
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 371677 [details] [diff] [review]
Proposed fix

We should take this on 1.9.1 if we want to take bug 457810 there.

        Attachment #371677 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 371677 [details] [diff] [review]
Proposed fix

a191=beltzner

        Attachment #371677 -
        Flags: approval1.9.1? → approval1.9.1+

          You need to log in
          before you can comment on or make changes to this bug.