Closed
Bug 485012
Opened 15 years ago
Closed 15 years ago
[FIX]Allow passing charset to CSSLoader->LoadSheet()
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: bjarne, Assigned: bzbarsky)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
16.59 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
See bug #457809#c16 It should be possible to pass the charset to CSSLoader->LoadSheet()
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #371677 -
Flags: superreview?(peterv)
Attachment #371677 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Bumping severity; I didn't make this clear in bug 457809, but the bug can cause preloading to screw up webpages. See the reftest in the patch for an example. It fails without this patch.
Severity: minor → major
Summary: Allow passing charset to CSSLoader->LoadSheet() → [FIX]Allow passing charset to CSSLoader->LoadSheet()
|
||
Updated•15 years ago
|
Attachment #371677 -
Flags: superreview?(peterv)
Attachment #371677 -
Flags: superreview+
Attachment #371677 -
Flags: review?(peterv)
Attachment #371677 -
Flags: review+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 371677 [details] [diff] [review] Proposed fix Almost forgot, new IID for nsICSSLoader?
|
|
Assignee | |
Comment 4•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/d20912121684 and http://hg.mozilla.org/mozilla-central/rev/6b0948c4355b (to fix the IID).
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 371677 [details] [diff] [review] Proposed fix We should take this on 1.9.1 if we want to take bug 457810 there.
Attachment #371677 -
Flags: approval1.9.1?
|
||
Comment 6•15 years ago
|
||
Comment on attachment 371677 [details] [diff] [review] Proposed fix a191=beltzner
Attachment #371677 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5aa7b020ef86
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•