Closed Bug 485012 Opened 11 years ago Closed 11 years ago

[FIX]Allow passing charset to CSSLoader->LoadSheet()

Categories

(Core :: DOM: HTML Parser, defect, major)

defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: bjarne, Assigned: bzbarsky)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

See bug #457809#c16

It should be possible to pass the charset to CSSLoader->LoadSheet()
Blocks: 457810
Attached patch Proposed fixSplinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #371677 - Flags: superreview?(peterv)
Attachment #371677 - Flags: review?(peterv)
Bumping severity; I didn't make this clear in bug 457809, but the bug can cause preloading to screw up webpages.  See the reftest in the patch for an example.  It fails without this patch.
Severity: minor → major
Summary: Allow passing charset to CSSLoader->LoadSheet() → [FIX]Allow passing charset to CSSLoader->LoadSheet()
Attachment #371677 - Flags: superreview?(peterv)
Attachment #371677 - Flags: superreview+
Attachment #371677 - Flags: review?(peterv)
Attachment #371677 - Flags: review+
Comment on attachment 371677 [details] [diff] [review]
Proposed fix

Almost forgot, new IID for nsICSSLoader?
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 371677 [details] [diff] [review]
Proposed fix

We should take this on 1.9.1 if we want to take bug 457810 there.
Attachment #371677 - Flags: approval1.9.1?
Comment on attachment 371677 [details] [diff] [review]
Proposed fix

a191=beltzner
Attachment #371677 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.