485049 - port xptcall to 64-bit Mac OS X

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Josh Aas]

We need to port xptcall to 64-bit Mac OS X.

Comment 1

[Josh Aas]

There is a mozconfig for 64-bit builds on Mac OS X on bug 468509. Currently the next compiler error on trunk is in xptcall.

Comment 2

[Josh Aas]

Attachment: use 64-bit Linux impl, v1.0

This patch points the build system at our 64-bit Linux xptcall implementation for Mac OS X builds. These are probably the files we should be using but they do not compile.

Comment 3

[Josh Aas]

Attachment: build errors 1

build errors for xptcall on Mac OS X using 64-bit Linux implementation

Comment 4

[Josh Aas]

Attachment: fix v0.6

This allows xptcall to build and xpcom to link, but I can't test it because I can't get an xpcshell building yet and it doesn't integrate with the Linux code, it just breaks it.

I need to integrate these changes into the Linux code and then we're probably good to go.

Jason Allum of IndyHall and RipItApp helped with this patch.

Comment 5

[Josh Aas]

Attachment: fix v1.0

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 372689 [details] [diff] [review]
fix v1.0

I think Benjamin should review this instead of me.

Comment 7

[Benjamin Smedberg]

Comment on attachment 372689 [details] [diff] [review]
fix v1.0

What's the difference between xptcstubs_x86_64_linux.cpp and xptcstubs_x86_64_darwin.cpp? Casual inspection says they are very similar: it would be nice to share that code instead of forking unless that's impossible.

Comment 8

[Benjamin Smedberg]

Comment on attachment 372689 [details] [diff] [review]
fix v1.0

ok, the assembly differences are great enough that it would be unreadable to use #defines in the same file. Bah.

Please add a header note to _darwin and _linux versions of this file to keep them in sync.

Comment 9

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b5414a0acb15