port xptcall to 64-bit Mac OS X

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
x86_64
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
We need to port xptcall to 64-bit Mac OS X.
(Assignee)

Updated

10 years ago
Blocks: 478687
(Assignee)

Comment 1

10 years ago
There is a mozconfig for 64-bit builds on Mac OS X on bug 468509. Currently the next compiler error on trunk is in xptcall.
(Assignee)

Comment 2

10 years ago
Created attachment 369145 [details] [diff] [review]
use 64-bit Linux impl, v1.0

This patch points the build system at our 64-bit Linux xptcall implementation for Mac OS X builds. These are probably the files we should be using but they do not compile.
(Assignee)

Comment 3

10 years ago
Created attachment 369146 [details]
build errors 1

build errors for xptcall on Mac OS X using 64-bit Linux implementation
(Assignee)

Comment 4

9 years ago
Created attachment 372486 [details] [diff] [review]
fix v0.6

This allows xptcall to build and xpcom to link, but I can't test it because I can't get an xpcshell building yet and it doesn't integrate with the Linux code, it just breaks it.

I need to integrate these changes into the Linux code and then we're probably good to go.

Jason Allum of IndyHall and RipItApp helped with this patch.
(Assignee)

Updated

9 years ago
Assignee: nobody → joshmoz
(Assignee)

Comment 5

9 years ago
Created attachment 372689 [details] [diff] [review]
fix v1.0
Attachment #372486 - Attachment is obsolete: true
Attachment #372689 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #372689 - Flags: review? → review?(dbaron)
Attachment #372689 - Flags: review?(dbaron) → review?(benjamin)
Comment on attachment 372689 [details] [diff] [review]
fix v1.0

I think Benjamin should review this instead of me.

Comment 7

9 years ago
Comment on attachment 372689 [details] [diff] [review]
fix v1.0

What's the difference between xptcstubs_x86_64_linux.cpp and xptcstubs_x86_64_darwin.cpp? Casual inspection says they are very similar: it would be nice to share that code instead of forking unless that's impossible.

Updated

9 years ago
Attachment #372689 - Flags: review?(benjamin) → review+

Comment 8

9 years ago
Comment on attachment 372689 [details] [diff] [review]
fix v1.0

ok, the assembly differences are great enough that it would be unreadable to use #defines in the same file. Bah.

Please add a header note to _darwin and _linux versions of this file to keep them in sync.
(Assignee)

Comment 9

9 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b5414a0acb15
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.