Closed Bug 485088 Opened 11 years ago Closed 11 years ago

use clearUserPref to set a userPref to default value in Session Restore tests

Categories

(Firefox :: Session Restore, defect, trivial)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 3.6a1

People

(Reporter: mkohler, Assigned: mkohler)

References

()

Details

Attachments

(1 file, 1 obsolete file)

IMHO it would be better to use clearUserPref to set the default value in Session Restore tests instead of saving the default value in a variable and then set it back with the value of this variable.

Simon: this needs try-catch, right?
Attached patch Patch v1 (obsolete) — Splinter Review
hope that is okay.
Attachment #369358 - Flags: review?(zeniko)
Comment on attachment 369358 [details] [diff] [review]
Patch v1

>-        // record the timestamp of sessionstore.js at the end of the private session
>+        // record the timestamp of sessionstore.js at the end of the private session    

Nit: Undo this change (trailing whitespace).

r+=me with this nit fixed, thanks.

BTW: For consistency, I'd be fine if you changed the tests for bug 350525 and bug 367052 to using clearUserPref as well.
Attachment #369358 - Flags: review?(zeniko) → review+
Attachment #369358 - Attachment is obsolete: true
Attachment #369551 - Flags: review?(zeniko)
Attachment #369551 - Flags: review?(zeniko) → review+
Keywords: checkin-needed
Depends on: 487059
http://hg.mozilla.org/mozilla-central/rev/50a692b9e897
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
You need to log in before you can comment on or make changes to this bug.