Closed Bug 485088 Opened 11 years ago Closed 11 years ago
User Pref to set a user Pref to default value in Session Restore tests
IMHO it would be better to use clearUserPref to set the default value in Session Restore tests instead of saving the default value in a variable and then set it back with the value of this variable. Simon: this needs try-catch, right?
hope that is okay.
Attachment #369358 - Flags: review?(zeniko)
Comment on attachment 369358 [details] [diff] [review] Patch v1 >- // record the timestamp of sessionstore.js at the end of the private session >+ // record the timestamp of sessionstore.js at the end of the private session Nit: Undo this change (trailing whitespace). r+=me with this nit fixed, thanks. BTW: For consistency, I'd be fine if you changed the tests for bug 350525 and bug 367052 to using clearUserPref as well.
Attachment #369358 - Flags: review?(zeniko) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.