485088 - use clearUserPref to set a userPref to default value in Session Restore tests

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Michael Kohler [:mkohler]]

IMHO it would be better to use clearUserPref to set the default value in Session Restore tests instead of saving the default value in a variable and then set it back with the value of this variable.

Simon: this needs try-catch, right?

Comment 1

[Michael Kohler [:mkohler]]

Attachment: Patch v1

hope that is okay.

Comment 2

[Simon Bünzli]

Comment on attachment 369358 [details] [diff] [review]
Patch v1

>-        // record the timestamp of sessionstore.js at the end of the private session
>+        // record the timestamp of sessionstore.js at the end of the private session    

Nit: Undo this change (trailing whitespace).

r+=me with this nit fixed, thanks.

BTW: For consistency, I'd be fine if you changed the tests for bug 350525 and bug 367052 to using clearUserPref as well.

Comment 3

[Michael Kohler [:mkohler]]

Attachment: Patch v2 (changes from comment 2 applied)

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/50a692b9e897

Comment 5

[Michael Kohler [:mkohler]]

[VERIFIED] http://hg.mozilla.org/mozilla-central/file/7fcb443a08ce/browser/components/sessionstore/test/browser/