485100 - Exchanging a letter of a tag name with its big/small equivalent removes tag from bookmark

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090322 Shiretoko/3.5b4pre ID:20090322030800

When you have a tagged bookmark and exchange a letter with its big/small equivalent letter, the tag gets removed from the bookmark. Other bookmarks with the same tag gets updated correctly.

Steps:
1. Create a fresh profile
2. Add at least two bookmarks with the same tag, e.g. "test"
3. Open Library and select the tag under the tag container
4. Select one of the bookmarks in the right pane
5. Rename the tag into "Test" inside the tag textfield
6. Hit tab

With step 6 the tag gets updated and is shown correctly under the tags container. But it is removed from the currently open bookmark. If you are working with a lot of bookmarks you will not recognize that it has been deleted but wonder why it isn't listed anymore under this tag. Adding dataloss keyword.

Comment 1

[Dietrich Ayala (:dietrich)]

reproducible, marking blocking+.

if you do this in the Library, i also noticed that the right-pane tag column for the other bookmarks is not updated.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's a regression against Firefox 3.0.x. XtC4UaLL already said he wanna find the regression range.

Comment 3

[Dietrich Ayala (:dietrich)]

(In reply to comment #1)
> i also noticed that the right-pane tag column
> for the other bookmarks is not updated.

this part is not a regression, is present in 3.0.

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

works:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081013 Minefield/3.1b2pre ID:20081013033718
http://hg.mozilla.org/mozilla-central/rev/163e9f2fa5c1
fails:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081014 Minefield/3.1b2pre ID:20081014032121
http://hg.mozilla.org/mozilla-central/rev/c6fcfc205aca

=> range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=163e9f2fa5c1&tochange=c6fcfc205aca

=> several checkins by Marco.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #3)
> this part is not a regression, is present in 3.0.

Sure? I don't think so. 3.0.7 works fine for me. As given by the regression range I would tend to say it has been regressed by the patch on bug 458043.

Comment 6

[Dietrich Ayala (:dietrich)]

(In reply to comment #5)
> (In reply to comment #3)
> > this part is not a regression, is present in 3.0.
> 
> Sure? I don't think so. 3.0.7 works fine for me. As given by the regression
> range I would tend to say it has been regressed by the patch on bug 458043.

yes, quite sure. but 458043 does not touch live update at all. again, i'm only referring to the bit about other items in the view not updating with the case change made to the tag.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh, i misunderstood. But updating the view in the right-pane works for me in 3.0 and 3.1, means all other bookmarks get the new tag name.

Comment 8

[Dietrich Ayala (:dietrich)]

Attachment: v1

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 369698 [details] [diff] [review]
v1

>diff --git a/browser/components/places/tests/chrome/test_bug485100-change-case-loses-tag.xul b/browser/components/places/tests/chrome/test_bug485100-change-case-loses-tag.xul
>+   - Contributor(s):
>+   -   Marco Bonardo <[e-mail]> (Original Author)

not me :)

>+      // Init panel
>+      ok(gEditItemOverlay, "gEditItemOverlay is in context");
>+      gEditItemOverlay.initPanel(itemId);
>+      

nit: trailing spaces

>+      // Cleanup.
>+      bs.removeItem(itemId);

removeItem does not yet remove tags, so please untagURI before removing it

r=me

Comment 10

[Dietrich Ayala (:dietrich)]

Attachment: for checkin

Comment 11

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/fc490eee2707

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified on Windows and OS X with builds like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090331 Minefield/3.6a1pre ID:20090331030637

Comment 13

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f97eb0ef27e7

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified on 1.9.1 with builds on OS X and Windows: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 ID:20090305133223

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv