Closed Bug 485187 Opened 11 years ago Closed 11 years ago

Rename gDownloadLastDir.path to gDownloadLastDir.file and gDownloadLastDirPath to gDownloadLastDirFile

Categories

(Toolkit :: Downloads API, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: ehsan, Assigned: ehsan)

References

()

Details

(Keywords: dev-doc-complete, verified1.9.1)

Attachments

(1 file)

Attached patch PatchSplinter Review
Follow-up from bug 464795 comment 17:

I missed this in the original review, but having a variable whose name includes
"path" (gDownloadLastDir.path/gDownloadLastDirPath) refer to an nsIFile instead
of an actual file path is fairly confusing.
Attachment #369285 - Flags: review?(gavin.sharp)
Attachment #369285 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/ac5110038dd4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Comment on attachment 369285 [details] [diff] [review]
Patch

This is a basic renaming patch, and poses very little risk.  It would be great to have this on 1.9.1 for API consistency between that branch and trunk.
Attachment #369285 - Flags: approval1.9.1?
Comment on attachment 369285 [details] [diff] [review]
Patch

a191=beltzner
Attachment #369285 - Flags: approval1.9.1? → approval1.9.1+
This should land on branch after bug 464795.
Depends on: 464795
Whiteboard: [checkin after bug 464795]
Target Milestone: --- → mozilla1.9.2a1
Blocks: 381157
Whiteboard: [checkin after bug 464795] → [needs 191 landing after bug 464795]
Please get this in right away.
This landed on 1.9.1 as part of bug 464795.
Keywords: fixed1.9.1
Whiteboard: [needs 191 landing after bug 464795]
Verified fixed on trunk and 1.9.1 based on code check-in and green boxes.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.