Closed Bug 485187 Opened 11 years ago Closed 11 years ago
Download Last Dir .path to g Download Last Dir .file and g Download Last Dir Path to g Download Last Dir File
Follow-up from bug 464795 comment 17: I missed this in the original review, but having a variable whose name includes "path" (gDownloadLastDir.path/gDownloadLastDirPath) refer to an nsIFile instead of an actual file path is fairly confusing.
Attachment #369285 - Flags: review?(gavin.sharp)
Attachment #369285 - Flags: review?(gavin.sharp) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 369285 [details] [diff] [review] Patch This is a basic renaming patch, and poses very little risk. It would be great to have this on 1.9.1 for API consistency between that branch and trunk.
Attachment #369285 - Flags: approval1.9.1?
Comment on attachment 369285 [details] [diff] [review] Patch a191=beltzner
Attachment #369285 - Flags: approval1.9.1? → approval1.9.1+
11 years ago
Whiteboard: [checkin after bug 464795]
Target Milestone: --- → mozilla1.9.2a1
Whiteboard: [checkin after bug 464795] → [needs 191 landing after bug 464795]
Added appropriate notes to the https://developer.mozilla.org/En/Firefox_3.5_for_developers article.
Please get this in right away.
This landed on 1.9.1 as part of bug 464795.
Whiteboard: [needs 191 landing after bug 464795]
Verified fixed on trunk and 1.9.1 based on code check-in and green boxes.
You need to log in before you can comment on or make changes to this bug.