485227 - Don't force link jemalloc on windows ce

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: removes force, explicitly links where needed

Forcing all binaries to link to link to jemalloc causes us to not be able to track the dependency correctly.

Comment 1

[Brian Crowder]

+ifdef WINCE
+EXTRA_LIBS += $(JEMALLOC_LIBS)
+endif
+
 LOCAL_INCLUDES += -I$(topsrcdir) -I..
 
 ifdef _MSC_VER
 ifdef WINCE
 WIN32_EXE_LDFLAGS += -ENTRY:mainACRTStartup
 endif
 endif


Should use the ifdef WINCE that's already in here for WIN32_EXE_LDFLAGS.  Might want to do the same with other spots, if you can find nearby ifdef WINCE (I bet they're there).

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 369327 [details] [diff] [review]
removes force, explicitly links where needed

r=me if you fix crowder's comment.

Comment 3

[Doug Turner (:dougt)]

this is wince only;  please also land on 1.9.1.

Comment 4

[Brian Crowder]

Comment on attachment 369327 [details] [diff] [review]
removes force, explicitly links where needed

r=me if you fix ted's comment about my comment.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/f6a23c2cb947

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 369327 [details] [diff] [review]
removes force, explicitly links where needed

can we get a rollup of this and the patch(es?) from bug 478044?

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8274e63ba0a5 (from bug 478044)