Closed Bug 485227 Opened 11 years ago Closed 11 years ago

Don't force link jemalloc on windows ce

Categories

(Firefox Build System :: General, defect)

ARM
Windows CE
defect
Not set

Tracking

(fennec1.0-wm+)

RESOLVED FIXED
Tracking Status
fennec 1.0-wm+ ---

People

(Reporter: blassey, Assigned: blassey)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Forcing all binaries to link to link to jemalloc causes us to not be able to track the dependency correctly.
Attachment #369327 - Flags: review?(crowder)
+ifdef WINCE
+EXTRA_LIBS += $(JEMALLOC_LIBS)
+endif
+
 LOCAL_INCLUDES += -I$(topsrcdir) -I..
 
 ifdef _MSC_VER
 ifdef WINCE
 WIN32_EXE_LDFLAGS += -ENTRY:mainACRTStartup
 endif
 endif


Should use the ifdef WINCE that's already in here for WIN32_EXE_LDFLAGS.  Might want to do the same with other spots, if you can find nearby ifdef WINCE (I bet they're there).
Attachment #369327 - Flags: review?(ted.mielczarek)
Attachment #369327 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 369327 [details] [diff] [review]
removes force, explicitly links where needed

r=me if you fix crowder's comment.
this is wince only;  please also land on 1.9.1.
Assignee: nobody → bugmail
tracking-fennec: --- → ?
tracking-fennec: ? → 1.0-wm+
Comment on attachment 369327 [details] [diff] [review]
removes force, explicitly links where needed

r=me if you fix ted's comment about my comment.
Attachment #369327 - Flags: review?(crowder) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/f6a23c2cb947
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #369327 - Flags: approval1.9.1?
Comment on attachment 369327 [details] [diff] [review]
removes force, explicitly links where needed

can we get a rollup of this and the patch(es?) from bug 478044?
Attachment #369327 - Flags: approval1.9.1? → approval1.9.1-
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.