485264 - Error message "dirname: extra operand `Files/Microsoft'" when running configure

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Wan-Teh Chang]

I use MozillaBuild 1.3 on Windows XP SP2, with Visual C++ 2005
Professional Edition SP1.

When I do "make -f client.mk build", the configure script emits
the following error messages:

  checking for ml... /c/Program Files/Microsoft Visual Studio 8/VC/BIN/ml
  dirname: extra operand `Files/Microsoft'
  Try `dirname --help' for more information.
  basename: extra operand `Visual'
  Try `basename --help' for more information.

The error messages from dirname are clearly caused by the spaces in
the pathname of ml.  In spite of these error messages, the build
is proceeding without problems.

Comment 1

[Benjamin Smedberg]

Attachment: Quote more in mozprog.m4, rev. 1

Comment 2

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/c98003848229

Comment 3

[Wan-Teh Chang]

Ben, thanks for the fix.  While verifying your bug fix,
I found that the original error messages from 'dirname'
and 'basename' are gone, but there is a new error message
from 'cd':

checking for ml... /c/Program Files/Microsoft Visual Studio 8/VC/BIN/ml
/c/firefox-tip/src/configure: cd: /c/Program: No such file or directory

Comment 4

[Makoto Kato [:m_kato]]

Attachment: patch for Comment #3

Comment 5

[Makoto Kato [:m_kato]]

Attachment: patch with js too

Comment 6

[Benjamin Smedberg]

Comment on attachment 370872 [details] [diff] [review]
patch with js too

pushed as http://hg.mozilla.org/mozilla-central/rev/63ef98ebb1ff

Comment 7

[Wan-Teh Chang]

Thanks.  This is the configure output now:

checking for ml... /c/Program Files/Microsoft Visual Studio 8/VC/BIN/ml