485499 - Unwanted Margin in Edit Bookmarks panel offsets Button and Title 1px to the right

Status: RESOLVED INCOMPLETE

(Firefox :: Theme, defect)

Description

[Luke Iliffe (Harlequin99)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090326 Minefield/3.6a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090326 Minefield/3.6a1pre

After Bug 484022 has been fixed the "Remove bookmark" button and the "Edit this bookmark" title are still 1px to the right of the left border of the text fields below. From Bug 484022 comment 31 it is possible this is due to an unwanted margin somewhere.

Reproducible: Always




Attaching a screenshot

Comment 1

[Luke Iliffe (Harlequin99)]

Attachment: Screenshot of the issue

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.

Comment 3

[kcarchana77]

I would like to work on this bug. It would be nice if you could assign this bug to me.

Comment 4

[kcarchana77]

As I am a beginner, could you please give me more details about where I should get started and which files should I be working on.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to kcarchana77 from comment #4)
> As I am a beginner, could you please give me more details about where I
> should get started and which files should I be working on.

Surely. I'm CC'ing Marco, who most likely can help you here to get started.

Comment 6

[kcarchana77]

Thank you, so much.

Comment 7

[Marco Bonardo [:mak]]

(In reply to kcarchana77 from comment #4)
> As I am a beginner, could you please give me more details about where I
> should get started and which files should I be working on.

Hi, first of all you can take a look at our introduction at https://developer.mozilla.org/en-US/docs/Introduction
You can use mxr to search through code:
http://mxr.mozilla.org/mozilla-central/

This specific panel is defined as editBookmarkPanel in browser.xul:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#147
The part containing the stuff you are looking for is editBookmarkPanelHeader
This part of the panel is moved into position after editBookmarkOverlay.xul is lazy loaded (see http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-places.js#134)

If you have specific questions feel free to ask, sorry for the delay in asnwering your questions.

Comment 8

[kcarchana77]

Attachment: I am not being able to reproduce the bug reported in the nightly version 29.0al. I am attaching the screenshot of it alongside.

I am not being able to reproduce the bug reported in the nightly version  29.0al. I am attaching the screenshot of it alongside.

Comment 9

[kcarchana77]

Attachment: DSC_4707.jpg

I am not being able to reproduce the bug reported in the nightly version  29.0al. I am attaching the screenshot of it alongside.

Comment 10

[Josiah Bruner [:jsbruner]]

This is only a Windows issue actually. Probably just needs a CSS change.

Comment 11

[Matthew N. [:MattN]]

The UI has changed to no longer have this problem.