485513 - MPL and line ending issues

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Jeff Dyer]

The following formatting issues should be resolved a.s.a.p.


MPL Issues:
===========
/eval/backlog.txt
/eval/documentation.txt
/eval/generate-keyword-lexer.as
/eval/generate-unicode-tables.c
/eval/smoketest.as
/eval/smoketest2.as
/eval/smoketest3.as
/MMgc/pyspy
/test/acceptance/abcasm/functionBindingAndTraits.abs
/test/acceptance/abcasm/semanticErrorDuplicateSlotName.abs
/test/acceptance/abcasm/stringEscapes.abs
/test/acceptance/abcasm/traitsSparseSlots.abs
/test/acceptance/as3/Statements/Exceptions/NestedTryBlockWithMultipleCatchBlocksTypeWithNoInnerCatchType.exitcode
/test/acceptance/as3/Statements/Exceptions/NestedTryWithMultipleCatchInsideFourthCatchWithoutMatchingCatch.exitcode
/test/acceptance/as3/Statements/Exceptions/NestedTryWithMultipleCatchInsideSecondCatchWithoutMatchingCatch.exitcode
/test/acceptance/ecma3/Exceptions/exception_010_rt.exitcode
/test/acceptance/ecma3/Exceptions/exception_011_rt.exitcode
/test/acceptance/mmgc/heap_stress.as
/utils/avmdiff.cfg
/utils/avmdiff.py
/utils/abcasm/test/functionBindingAndTraits.abs
/utils/abcasm/test/semanticErrorDuplicateSlotName.abs
/utils/abcasm/test/stringEscapes.abs
/utils/abcasm/test/traitsSparseSlots.abs


Line Ending Issues:
===================
/extensions/ST_mmgc_basics.cpp
/shell/PosixFile.cpp
/shell/WinFile.cpp
/utils/abcasm/extras/abcasm.vim
/utils/abcasm/test/mops.abs

Comment 1

[Lars T Hansen]

How come /doc/verifier.html does not show up with an MPL issue, when eg /eval/backlog.txt does.  Is there magic somewhere?  I want access to it...

Comment 2

[Jeff Dyer]

cc'ing brent, who I think knows where is the magic.

Comment 3

[Brent Baker]

Magic lives in these 2 files:

http://asteam.macromedia.com/hg/qe/
qe\buildbot\slaves\tamarin-redux\branch\lineending_excluded.txt
qe\buildbot\slaves\tamarin-redux\branch\mpl_excluded.txt

I can easily update these for you instead of having to clone if you want. We have a deep backlog item for moving the "build assets" out of this repository and into the redex/central repos so that are not "hidden"

Comment 4

[Lars T Hansen]

Thanks.

It would be great if you could add these two to the mpl_excluded file:

/eval/backlog.txt
/eval/documentation.txt

Comment 5

[Brent Baker]

These files are now excluded from the MPL check:
/eval/backlog.txt
/eval/documentation.txt

Comment 6

[Edwin Smith]

seesh - put the magic in the same repository as the files, please!

Comment 7

[Lars T Hansen]

Fixed line ending on WinFile.cpp, PosixFile.cpp
Fixed MPL on files in eval/

Comment 8

[Brent Baker]

Line ending and MPL issues are currently all clear, closing this issue.

There is an item on the product backlog to move the buildscripts out of the QE repository and into the tamarin repo. 

#219 - Infrastructure
Title: Move the buildscripts used in the build system out of the QE repository and into the tamarin repository.

Story: As a developer I would like to be able to modify and run locally the build scripts that are used in build system.

Acceptance: Finished when all necessary scripts for building are in the tamari-redux repository and there is a way for developers to run the exact same build scripts locally so they can ensure that their changes are going to be fine in the build system.