If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

MPL and line ending issues

VERIFIED FIXED in flash10.1

Status

Tamarin
Virtual Machine
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Jeff Dyer, Assigned: Brent Baker)

Tracking

unspecified
flash10.1

Details

(Reporter)

Description

9 years ago
The following formatting issues should be resolved a.s.a.p.


MPL Issues:
===========
/eval/backlog.txt
/eval/documentation.txt
/eval/generate-keyword-lexer.as
/eval/generate-unicode-tables.c
/eval/smoketest.as
/eval/smoketest2.as
/eval/smoketest3.as
/MMgc/pyspy
/test/acceptance/abcasm/functionBindingAndTraits.abs
/test/acceptance/abcasm/semanticErrorDuplicateSlotName.abs
/test/acceptance/abcasm/stringEscapes.abs
/test/acceptance/abcasm/traitsSparseSlots.abs
/test/acceptance/as3/Statements/Exceptions/NestedTryBlockWithMultipleCatchBlocksTypeWithNoInnerCatchType.exitcode
/test/acceptance/as3/Statements/Exceptions/NestedTryWithMultipleCatchInsideFourthCatchWithoutMatchingCatch.exitcode
/test/acceptance/as3/Statements/Exceptions/NestedTryWithMultipleCatchInsideSecondCatchWithoutMatchingCatch.exitcode
/test/acceptance/ecma3/Exceptions/exception_010_rt.exitcode
/test/acceptance/ecma3/Exceptions/exception_011_rt.exitcode
/test/acceptance/mmgc/heap_stress.as
/utils/avmdiff.cfg
/utils/avmdiff.py
/utils/abcasm/test/functionBindingAndTraits.abs
/utils/abcasm/test/semanticErrorDuplicateSlotName.abs
/utils/abcasm/test/stringEscapes.abs
/utils/abcasm/test/traitsSparseSlots.abs


Line Ending Issues:
===================
/extensions/ST_mmgc_basics.cpp
/shell/PosixFile.cpp
/shell/WinFile.cpp
/utils/abcasm/extras/abcasm.vim
/utils/abcasm/test/mops.abs

Comment 1

9 years ago
How come /doc/verifier.html does not show up with an MPL issue, when eg /eval/backlog.txt does.  Is there magic somewhere?  I want access to it...
(Reporter)

Comment 2

9 years ago
cc'ing brent, who I think knows where is the magic.
(Assignee)

Comment 3

9 years ago
Magic lives in these 2 files:

http://asteam.macromedia.com/hg/qe/
qe\buildbot\slaves\tamarin-redux\branch\lineending_excluded.txt
qe\buildbot\slaves\tamarin-redux\branch\mpl_excluded.txt

I can easily update these for you instead of having to clone if you want. We have a deep backlog item for moving the "build assets" out of this repository and into the redex/central repos so that are not "hidden"

Comment 4

9 years ago
Thanks.

It would be great if you could add these two to the mpl_excluded file:

/eval/backlog.txt
/eval/documentation.txt
(Assignee)

Comment 5

9 years ago
These files are now excluded from the MPL check:
/eval/backlog.txt
/eval/documentation.txt

Comment 6

9 years ago
seesh - put the magic in the same repository as the files, please!

Updated

9 years ago
Assignee: nobody → brbaker

Comment 7

9 years ago
Fixed line ending on WinFile.cpp, PosixFile.cpp
Fixed MPL on files in eval/

Updated

9 years ago
Target Milestone: --- → flash10.x
(Assignee)

Comment 8

9 years ago
Line ending and MPL issues are currently all clear, closing this issue.

There is an item on the product backlog to move the buildscripts out of the QE repository and into the tamarin repo. 

#219 - Infrastructure
Title: Move the buildscripts used in the build system out of the QE repository and into the tamarin repository.

Story: As a developer I would like to be able to modify and run locally the build scripts that are used in build system.

Acceptance: Finished when all necessary scripts for building are in the tamari-redux repository and there is a way for developers to run the exact same build scripts locally so they can ensure that their changes are going to be fine in the build system.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.