485516 - "Phonetic" labels are miss-aligned

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Atsushi Sakai]

Attachment: screenshot of problem

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090327 Shredder/3.0b3pre

Steps to reproduce:
1. Start Thunderbird.
2. Change mail.addr_book.show_phonetic_fields to "true"
3. Open Address Book -> New Contact

Actual result:
"Phonetic:" labels are miss-aligned (upper than other labels).

Expected result:
All labels should be aligned correctly.

Comment 1

[Atsushi Sakai]

Attachment: Patch v1.0

Comment 2

[Mark Banner (:standard8)]

This isn't a regression from bug 63941. The issue was there before, and bug
63941 actually improved the situation for the rest of the address book card.

Comment 3

[Atsushi Sakai]

Attachment: screenshot of 2008-11-05-03-comm-central

(In reply to comment #2)
> This isn't a regression from bug 63941. The issue was there before, and bug
> 63941 actually improved the situation for the rest of the address book card.

2008-11-05-03-comm-central:
- The vertical positions of "First:" and "Phonetic:" are same.
- The vertical positions of "Last:" and "Phonetic:" are same.

2008-11-06-03-comm-central:
miss-aligned.

And bug 63941 was checked-in in this range.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> 2008-11-05-03-comm-central:
> - The vertical positions of "First:" and "Phonetic:" are same.
> - The vertical positions of "Last:" and "Phonetic:" are same.

Are the same *incorrect* alignment.

> 2008-11-06-03-comm-central:
> miss-aligned.

Made First and Last central, but didn't touch the phonetic labels.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 369667 [details] [diff] [review]
Patch v1.0

Thanks for fixing this, r/sr=me. I have already pushed it as well:

http://hg.mozilla.org/comm-central/rev/176da11bcfa5