Tabs engine fails with 'tabChild is undefined'

RESOLVED FIXED in 0.3

Status

P1
normal
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: hello, Unassigned)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
I'm seeing this in my log with 0.2.118 (latest trunk atm):

Engine.Tabs          ERROR	Could not process incoming record: tabChild is undefined (module:tabs.js:229 :: TypeError)
(Reporter)

Updated

10 years ago
Priority: -- → P1

Comment 1

10 years ago
The line before that is:

for each (let tabChild in tabContainer.childNodes)

so I don't see how tabChild could be undefined, unless childNodes actually contains entries that are "undefined" instead of nodes.  I haven't been able to replicate this; I have a hunch that it's a side effect of some unusual state in the tab container.  Did you have any weird tabs open when it happened?  Any other extensions that do things to the tabs list?  Any clue about how to replicate would be good.

For now, I added code in http://hg.mozilla.org/labs/weave/rev/3b88ce58b6ba  that will handle this case and log a warning about it.  So people with this problem will be able to finish syncing, and we'll see warnings about it if it recurs.

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: Weave → General
Product: Mozilla Labs → Weave
QA Contact: weave → general
You need to log in before you can comment on or make changes to this bug.