Closed Bug 485539 Opened 13 years ago Closed 13 years ago

Tabs engine fails with 'tabChild is undefined'

Categories

(Cloud Services :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hello, Unassigned)

References

Details

I'm seeing this in my log with 0.2.118 (latest trunk atm):

Engine.Tabs          ERROR	Could not process incoming record: tabChild is undefined (module:tabs.js:229 :: TypeError)
Priority: -- → P1
The line before that is:

for each (let tabChild in tabContainer.childNodes)

so I don't see how tabChild could be undefined, unless childNodes actually contains entries that are "undefined" instead of nodes.  I haven't been able to replicate this; I have a hunch that it's a side effect of some unusual state in the tab container.  Did you have any weird tabs open when it happened?  Any other extensions that do things to the tabs list?  Any clue about how to replicate would be good.

For now, I added code in http://hg.mozilla.org/labs/weave/rev/3b88ce58b6ba  that will handle this case and log a warning about it.  So people with this problem will be able to finish syncing, and we'll see warnings about it if it recurs.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: Weave → General
Product: Mozilla Labs → Weave
QA Contact: weave → general
Blocks: 500598
You need to log in before you can comment on or make changes to this bug.