Hide date containers not containing additional entries compared to previous ones.

VERIFIED FIXED in Firefox 3.6a1

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Simon Bünzli, Assigned: mak)

Tracking

({verified1.9.1})

3.5 Branch
Firefox 3.6a1
verified1.9.1
Points:
---
Bug Flags:
wanted-firefox3.5 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

15.55 KB, patch
dietrich
: review+
beltzner
: ui-review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
On a clean profile, I get three buckets after visiting a single page:

* Today
* Last 7 days
* This month

The second and third bucket don't contain additional information, even though their presence implies to me that there's more history available than just today's (which there isn't).

On another profile I've limited history to 5 days. There, the "This month" bucket will always just be UI-noise (being equal to the "Last 7 days" bucket).

So why not just hide the "Last 7 days" bucket when there are no pages older than yesterday and the "This month" bucket when there are no pages older than 7 days?
(Assignee)

Comment 1

9 years ago
that's by design, see discussion in the original bug, overlapping was requested expliticly
(Reporter)

Comment 2

9 years ago
(In reply to comment #1)
This bug isn't about the fact that the buckets overlap, but that it's possible for several buckets to be identical, which IMO just makes the UI noisier and gives a slightly wrong impression (that there are history entries older than in the bucket above).
Keywords: uiwanted
(Assignee)

Comment 3

9 years ago
we can do that eventually, leave them overlapped but don't show if there are not additional entries.
Assignee: nobody → mak77
Summary: Hide buckets not containing additional entries → Hide date containers not containing additional entries compared to previous ones.
(Assignee)

Comment 4

9 years ago
Created attachment 370382 [details] [diff] [review]
patch v1.0

So with this patch:
"last 7 days" is visible only if there are visits older than 2 days but younger than 7 days
"this month" is visible only if there are visits older than 7 days but younger than month's start (so first 7 days of the month it will be always hidden)
Attachment #370382 - Flags: ui-review?(beltzner)
Attachment #370382 - Flags: review?(dietrich)
(Assignee)

Comment 5

9 years ago
ps: contents of the containers do not change with this patch, they are simply hidden in above cases, but "last 7 days" will always contain everything from 7 days ago to now.
Flags: wanted-firefox3.5?
(Assignee)

Updated

9 years ago
Flags: in-testsuite?
Attachment #370382 - Flags: review?(dietrich) → review+
Comment on attachment 370382 [details] [diff] [review]
patch v1.0

r=me, with tests for each of the containers that this change affects.
Flags: wanted-firefox3.5? → wanted-firefox3.5+
(Assignee)

Comment 7

9 years ago
Created attachment 370532 [details] [diff] [review]
patch v1.1

with a somehow deeper test, Dietrich, do you think this is enough or should i create a completely new unit test just for this?
Attachment #370382 - Attachment is obsolete: true
Attachment #370532 - Flags: ui-review?(beltzner)
Attachment #370532 - Flags: review?(dietrich)
Attachment #370382 - Flags: ui-review?(beltzner)
Comment on attachment 370532 [details] [diff] [review]
patch v1.1

thanks, that's great, r=me
Attachment #370532 - Flags: review?(dietrich) → review+
Attachment #370532 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 370532 [details] [diff] [review]
patch v1.1

Please land on trunk for baking ASAP.
(Assignee)

Comment 10

9 years ago
http://hg.mozilla.org/mozilla-central/rev/f0507c4d0abb
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
(Assignee)

Updated

9 years ago
Whiteboard: [baking on trunk]
(Assignee)

Updated

9 years ago
Keywords: uiwanted
(Assignee)

Updated

9 years ago
Attachment #370532 - Flags: approval1.9.1?
(Assignee)

Comment 11

9 years ago
Comment on attachment 370532 [details] [diff] [review]
patch v1.1

asking approval after 2 days of baking, this makes the sidebar experience better not showing useless date containers, and is automatically tested.
Comment on attachment 370532 [details] [diff] [review]
patch v1.1

a191=beltzner
Attachment #370532 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 13

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e6cd714d3451
Keywords: fixed1.9.1
Whiteboard: [baking on trunk]
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre)
Gecko/20090414 Shiretoko/3.5b4pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.