Last Comment Bug 485713 - Files added by Red Hat recently have missing texts in license headers.
: Files added by Red Hat recently have missing texts in license headers.
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All All
: P2 trivial (vote)
: 3.12.3
Assigned To: Elio Maldonado
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-28 10:24 PDT by Wan-Teh Chang
Modified: 2009-04-06 13:59 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Add missing text to copyright section. (888 bytes, patch)
2009-03-28 11:50 PDT, Elio Maldonado
nelson: review+
Details | Diff | Splinter Review
Add missing text to copyright section. (5.48 KB, patch)
2009-03-28 11:54 PDT, Elio Maldonado
nelson: review+
Details | Diff | Splinter Review

Comment 1 Elio Maldonado 2009-03-28 11:50:26 PDT
Created attachment 369831 [details] [diff] [review]
Add missing text to copyright section.
Comment 2 Elio Maldonado 2009-03-28 11:51:22 PDT
Comment on attachment 369831 [details] [diff] [review]
Add missing text to copyright section.

Fixes item #1 in the bug report.
Comment 3 Elio Maldonado 2009-03-28 11:54:28 PDT
Created attachment 369832 [details] [diff] [review]
Add missing text to copyright section.

Doing items 2 though 5 as well.
Comment 4 Nelson Bolyard (seldom reads bugmail) 2009-03-28 14:22:34 PDT
Comment on attachment 369831 [details] [diff] [review]
Add missing text to copyright section.

This patch is fine, except for one thing.

>- * The Original Code is the Netscape security libraries. *
>+ * The Original Code is Netscape Security Libraries.
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
We now call them the "Network Security Services".
We don't label them as Netscape, and we use the word "Services".
Please fix that when you commit this change.  
No further review of the corrected patch is necessary.
Comment 5 Nelson Bolyard (seldom reads bugmail) 2009-03-28 14:25:35 PDT
Comment on attachment 369832 [details] [diff] [review]
Add missing text to copyright section.


>- * The Initial Developer of the Original Code is Red Hat, Inc, 2008.
>+ * The Original Code is Netscape Security Libraries.

Please change all the files patched by this patch to say 
"Network Security Services" instead of "Netscape Security Libraries".
After making that change, you may commit the modified patch without 
further review.
Comment 6 Wan-Teh Chang 2009-03-28 16:42:30 PDT
Comment on attachment 369832 [details] [diff] [review]
Add missing text to copyright section.

The new license headers in stubs.h and stubs.c are still missing the
lines from
  ***** BEGIN LICENSE BLOCK *****
up to
  * http://www.mozilla.org/MPL/

Note You need to log in before you can comment on or make changes to this bug.