Closed
Bug 485713
Opened 15 years ago
Closed 15 years ago
Files added by Red Hat recently have missing texts in license headers.
Categories
(NSS :: Libraries, defect, P2)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.3
People
(Reporter: wtc, Assigned: elio.maldonado.batiz)
Details
Attachments
(2 files)
888 bytes,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
5.48 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
The following files added by Red Hat recently have missing texts in the MPL triple license headers: 1. lib/util/nssutil.h http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/util/nssutil.h&rev=1.1&mark=17,18 2. lib/freebl/intel-aes.h http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/freebl/intel-aes.h&rev=1.1&mark=14 3. lib/freebl/intel-aes.s http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/freebl/intel-aes.s&rev=1.1&mark=14 4. lib/freebl/stubs.h: no license header http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/freebl/stubs.h&rev=1.1&mark=1-5 5. lib/freebl/stubs.c: no license header http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/freebl/stubs.c&rev=1.2&mark=1-5 The standard MPL triple license boilerplate is at http://www.mozilla.org/MPL/boilerplate-1.1/mpl-tri-license-c.
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #369831 -
Flags: review?
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 369831 [details] [diff] [review] Add missing text to copyright section. Fixes item #1 in the bug report.
Assignee | ||
Comment 3•15 years ago
|
||
Doing items 2 though 5 as well.
Attachment #369832 -
Flags: review?
Updated•15 years ago
|
Attachment #369831 -
Flags: review? → review+
Comment 4•15 years ago
|
||
Comment on attachment 369831 [details] [diff] [review] Add missing text to copyright section. This patch is fine, except for one thing. >- * The Original Code is the Netscape security libraries. * >+ * The Original Code is Netscape Security Libraries. ^^^^^^^^^^^^^^^^^^^^^^^^^^^ We now call them the "Network Security Services". We don't label them as Netscape, and we use the word "Services". Please fix that when you commit this change. No further review of the corrected patch is necessary.
Updated•15 years ago
|
Priority: -- → P2
Target Milestone: --- → 3.12.3
Version: 3.12.3 → trunk
Updated•15 years ago
|
Attachment #369832 -
Flags: review? → review+
Comment 5•15 years ago
|
||
Comment on attachment 369832 [details] [diff] [review] Add missing text to copyright section. >- * The Initial Developer of the Original Code is Red Hat, Inc, 2008. >+ * The Original Code is Netscape Security Libraries. Please change all the files patched by this patch to say "Network Security Services" instead of "Netscape Security Libraries". After making that change, you may commit the modified patch without further review.
Reporter | ||
Comment 6•15 years ago
|
||
Comment on attachment 369832 [details] [diff] [review] Add missing text to copyright section. The new license headers in stubs.h and stubs.c are still missing the lines from ***** BEGIN LICENSE BLOCK ***** up to * http://www.mozilla.org/MPL/
Assignee | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•