485720 - Text Descenders Do Not Display Properly In SeaMonkey Default Theme

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[therube]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090327 SeaMonkey/2.0b1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090327 SeaMonkey/2.0b1pre

 
Characters with descenders; [ ] g j p q y
do not display correct in (XP) SeaMonkey /Default Theme/.


Reproducible: Always

Steps to Reproduce:

1.  Open a Find dialog, Ctrl+F
2.  Type in some characters with descenders; [ ] g j p q y

Actual Results:  

Those characters do no display properly.
They're truncated at the bottom.


Expected Results:  
 
Characters with descenders should display properly.



This problem does not occur in the Modern theme.

Comment 1

[therube]

Attachment: Top is Default Theme, bottom is Modern

Comment 2

[therube]

Preliminary regression range:

10/27/2008 working
11/30/2008 broken

Comment 3

[Philip Chee]

You need to switch the OS theme in Windows XP to Windows Classic to see this.

Comment 4

[therube]

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-11-12&enddate=2008-11-13

Comment 5

[[e-mail]]

Attachment: Proposed patch

For some reason XUL layout is miscalculating the height of the textbox if its parent hbox is flexible. In fact, nearly all of the flex attributes in the dialog are bogus, so I removed them too. I also tweaked some align attributes to make the dialog look slightly nicer.

Comment 7

[[e-mail]]

Pushed changeset a15f09d02859 to mozilla-central.

Comment 8

[David E. Ross]

Was this fixed in a theme?  If so, is an end-user release available so that I don't have to wait for the next update of SeaMonkey?

Comment 9

[[e-mail]]

Sorry, but this had to be fixed in content, rather than a theme.