485728 - TUnit test_intl_locale tests get executed twice now

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Serge Gautherie (:sgautherie)]

This happens on MacOSX and Windows, but not Linux;
it's trunk only;
I reproduce it on my local SeaMonkey/1.9.2.

Regression timeframe:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-03-18+01%3A22%3A50&enddate=2009-03-18+01%3A47%3A29
caused by
http://hg.mozilla.org/mozilla-central/rev/81dc4af9e961

This directory is executed both from 'intl/locale/tests' and 'intl/locale/tests_multilocale'.

Before:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237364751.1237377089.15377.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/18 01:25:51

make[3]: Entering directory `/e/builds/moz2_slave/mozilla-central-win32-unittest/build/objdir/intl/locale/tests'
d:/mozilla-build/python25/python.exe -u \
          /e/builds/moz2_slave/mozilla-central-win32-unittest/build/testing/xpcshell/runxpcshelltests.py \
          ../../../dist/bin/xpcshell \
          /e/builds/moz2_slave/mozilla-central-win32-unittest/build \
          ../../../_tests/xpcshell/test_intl_locale/unit
}

After:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366264.1237378437.22583.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/18 01:51:04

make[3]: Entering directory `/e/builds/moz2_slave/mozilla-central-win32-unittest/build/objdir/intl/locale/tests'
d:/mozilla-build/python25/python.exe -u \
          /e/builds/moz2_slave/mozilla-central-win32-unittest/build/testing/xpcshell/runxpcshelltests.py \
          ../../../dist/bin/xpcshell \
          /e/builds/moz2_slave/mozilla-central-win32-unittest/build \
          ../../../_tests/xpcshell/test_intl_locale/unit
...
make[3]: Entering directory `/e/builds/moz2_slave/mozilla-central-win32-unittest/build/objdir/intl/locale/tests_multilocale'
d:/mozilla-build/python25/python.exe -u \
          /e/builds/moz2_slave/mozilla-central-win32-unittest/build/testing/xpcshell/runxpcshelltests.py \
          ../../../dist/bin/xpcshell \
          /e/builds/moz2_slave/mozilla-central-win32-unittest/build \
          ../../../_tests/xpcshell/test_intl_locale/unit
}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Fix MODULE name [Checkin: Comment 4]

Untested, but trivial.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> (Av1) Fix MODULE name

This is the easiest fix,
though renaming the directory from 'tests_multilocale/unit' to 'tests/multilocale' may be better. Not sure.

Comment 3

[Simon Montagu :smontagu]

(In reply to comment #2)
> This is the easiest fix,
> though renaming the directory from 'tests_multilocale/unit' to
> 'tests/multilocale' may be better. Not sure.

I think I prefer it this way.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 372893 [details] [diff] [review]
(Av1) Fix MODULE name
[Checkin: Comment 4]


http://hg.mozilla.org/mozilla-central/rev/32dc8d681ecf


1.9.1 landing already included in bug360018 comment 59.

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239884280.1239887836.14926.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/04/16 05:18:00

V.Fixed