485732 - nsslowcert_OpenCertDB leaks a PRMonitor on failure

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

nsslowcert_OpenCertDB allocates a PRMonitor, and then calls 
nsslowcert_OpenPermCertDB.  If that call fails, nsslowcert_OpenCertDB 
returns without destroying the PRMonitor.  This generally happens during
a call to NSS_Init, and the failure causes NSS_Init to fail, so the 
application does not call NSS_Shutdown.  Consequently, the PRMonitor is 
leaked.  See bug 447845 for the leak stack.

This has raised the questions: 
When NSS_Init fails, should an application try to call NSS_Shutdown anyway?  
Would doing so fix this leak?

Comment 2

[:Cykesiopka]

Attachment: bug485732_v1.patch

Comment 3

[Elio Maldonado]

Comment on attachment 8428438 [details] [diff] [review]
bug485732_v1.patch

Review of attachment 8428438 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/softoken/legacydb/pcertdb.c
@@ +4597,5 @@
>  	goto loser;
>      }
>  
>      return (SECSuccess);
>      

Nitpick: whitespace

Comment 4

[:Cykesiopka]

Attachment: bug485732_v2.patch

+ Fix whitespace

Thanks for the review!

Comment 5

[Robert Relyea]

Comment on attachment 8430457 [details] [diff] [review]
bug485732_v2.patch

Review of attachment 8430457 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a new version of the patch. It now has 2 reviews (elio and mine).

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/2a654ae92851