485833 - Add validity checks for maxVersions

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, enhancement)

Description

[Dave Townsend [:mossop]]

In bug 479095 comment 5 vlad suggests that maybe we should stop add-on authors being able to mistakenly use things like 3.* as a maxVersion. This doesn't seem unreasonable so I think maybe implementing the following restrictions should cover it. We'd probably ignore these in the event that checkCompatibility was false.

1. Ignore any maxVersion with a "*" anywhere but the last character.
2. Any maxVersion with a "*" is ignored if it contains less than a defined number of version parts (separated by ".").

The application would then ship with an optional preference to set the minimum number of version parts. No preference would default to 0, so effectively there would be no restriction, keeping the behaviour the same as now. Firefox would ship with a value of 3 to allow 3.5.* but not 3.*.

Comment 1

[Andy McKay]

Due to a long period of inactivity on this bug (6.49 years), I am intending to close this bug within a month or so in accordance with: https://wiki.mozilla.org/Add-ons/OldBugs Please remove [intent-to-close] from the whiteboard and comment on this bug if you would like to keep it open.