485840 - crash [@ XPCJSRuntime::GCCallback(JSContext*,JSGCStatus)]

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bill Gianopoulos [:WG9s]]

bp-6acde9b0-b7e6-4045-a841-2876d2090329

Crashes happen at random times.  This one occured when clicking on the refresh toolbar button.

Comment 1

[Bill Gianopoulos [:WG9s]]

From the Crash Reporter stats, this appears to have started with the 20090325030632 Linux build and Windows 20090326050203 builds.

There was no 3/25 Windows nightly. So, it would appear that this regressed between the 20090324 and 20090325 nightly builds

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6cfe70091cfc&tochange=c4c84ba77c47

Comment 2

[Brendan Eich [:brendan]]

Bill, this is only on m-c builds, not tm or 1.9.1?

/be

Comment 3

[Bill Gianopoulos [:WG9s]]

(In reply to comment #2)
> Bill, this is only on m-c builds, not tm or 1.9.1?
> 
> /be

I am seeing this on mozilla-central builds.  Crash reporter stats only show it on m-c also.

I have not tried tracemonkey builds.

I have had several crashes today, but becuase of being busier than normal at work, I had not tested recent builds very much.  Unfortunately, all the crashes except this one were either under Linux, where crash reports are useless becuase they don't work right on AMD64 processors, or on my onwn builds that obviously don't run crash reporter.

However, this is the number 2 topcrash for the week according to Crash Reporter, so there should be plenty of stack traces to work from.

Comment 4

[Bill Gianopoulos [:WG9s]]

Oh this crash was also with default JIT settings.  chrome false; content true.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

This is fallout from bug 474369 -- patch in a jiffy (sorry for not catching it during review).

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

This code has to be reentrant-safe.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/a1ee948734d4

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

And http://hg.mozilla.org/mozilla-central/rev/9b8be3ba5284 fixes a style nitpick I introduced.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)